build(deps): up PHP version to 8.2#1592
Open
MrKrasnov wants to merge 3 commits into
Open
Conversation
WerySkok
requested changes
May 23, 2026
Author
|
@WerySkok а что конкретно ты видишь необходимым тут исправлять ? Вполне логично выводить ошибку если версия php старее чем 7.3.0 |
Author
Member
|
@MrKrasnov Ну так апни до 8.2 |
Member
WerySkok
requested changes
May 24, 2026
Member
WerySkok
left a comment
There was a problem hiding this comment.
В самом условии тоже исправь до "8.2.0", без этого не приму
Author
|
Окей, подправил условие. 1ce4aa6 Мое мнение я бы вообще в этом ПР не трогал bootstrap.php, но дело конечно ваше) Изначально цель этого ПР была устранить ошибки при сборке компосера, а собирать композер появилась необходимость так как варнинги и ошибки светились в phpstorm. Изначально весь проект разворачиваю в докере и там vendor сам создается с необходимыми пакетами, по этому все эти танцы только ради phpstorm. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


No description provided.