Skip to content

chore: Replace docker builder#814

Merged
Jozott00 merged 25 commits intomasterfrom
feature/replace-docker-builder
Mar 24, 2026
Merged

chore: Replace docker builder#814
Jozott00 merged 25 commits intomasterfrom
feature/replace-docker-builder

Conversation

@kper
Copy link
Copy Markdown
Contributor

@kper kper commented Mar 14, 2026

We noticed many flaky tests, even though, the compiler builds were successful. We concluded that the issue is the legacy docker builder. However, the testcontainer dependency does not support the newer alternative - buildkit. This PR introduces a new dependency that builds the image with buildkit and then runs the image with testcontainers. Because buildkit supports cached layers at build-time, we can drop the redis cache approach.

@github-actions github-actions Bot added the enhancement New feature or request label Mar 14, 2026
@kper kper force-pushed the feature/replace-docker-builder branch 6 times, most recently from 3a6b941 to c3ff101 Compare March 19, 2026 11:55
@kper kper requested a review from Jozott00 March 19, 2026 14:53
Copy link
Copy Markdown
Contributor

@Jozott00 Jozott00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really nice!
Just two things: The ISS builds are not cached and the docker image remover only takes care of LCB images.

EDIT: Before merging this, I would also run the CI a couple of times to ensure that it doesn’t take longer than before.

Comment thread vadl/test/vadl/iss/CosimTest.java Outdated
Comment thread vadl/test/vadl/iss/QemuIssTest.java Outdated
Comment thread vadl/test/vadl/RemovingDockerImagesTeardown.java
@kper kper force-pushed the feature/replace-docker-builder branch 2 times, most recently from 2afaad8 to d72cd12 Compare March 20, 2026 14:40
@kper
Copy link
Copy Markdown
Contributor Author

kper commented Mar 20, 2026

Wait, the image reuse mechanism does not work yet

@kper kper force-pushed the feature/replace-docker-builder branch 4 times, most recently from 83a7646 to 471ba02 Compare March 23, 2026 07:41
Comment thread vadl/test/vadl/iss/QemuIssTest.java Outdated
@kper kper force-pushed the feature/replace-docker-builder branch from 471ba02 to 13582c3 Compare March 23, 2026 17:19
@kper kper force-pushed the feature/replace-docker-builder branch from 13582c3 to c7df5fe Compare March 24, 2026 07:19
@Jozott00 Jozott00 merged commit 8851549 into master Mar 24, 2026
7 checks passed
@Jozott00 Jozott00 deleted the feature/replace-docker-builder branch March 24, 2026 09:04
@Jozott00 Jozott00 added the skip-changelog This PR will not show up in the release changelog label Mar 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request skip-changelog This PR will not show up in the release changelog

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants