Change: Include .nml, .lng, and custom_tags.txt files in -M output#417
Open
SpaceManiac wants to merge 1 commit intoOpenTTD:masterfrom
Open
Change: Include .nml, .lng, and custom_tags.txt files in -M output#417SpaceManiac wants to merge 1 commit intoOpenTTD:masterfrom
SpaceManiac wants to merge 1 commit intoOpenTTD:masterfrom
Conversation
SpaceManiac
commented
Feb 17, 2026
|
|
||
|
|
||
| def read_extra_commands(custom_tags_file): | ||
| def read_extra_commands(custom_tags_file, dependencies: list[str]): |
Author
There was a problem hiding this comment.
: list[str] annotation included out of habit to make autocomplete work. Can trash it if it's too against the grain here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depfile output is useful, but it's bad form for it to be incomplete. Changes to input
.nmlfile, the.lngfiles, the directory globbed to discover.lngfiles, and (if it exists)custom_tags.txtshould all trigger builds, so include them in the-Moutput.A remaining corner case is that the first-time creation of
custom_tags.txtis not caught.