Skip to content

fix: Add missing locales on SK date picker - #1009

Merged
moustachu merged 1 commit into
developfrom
fix/missing_locales_dates_sk
Jul 24, 2026
Merged

fix: Add missing locales on SK date picker#1009
moustachu merged 1 commit into
developfrom
fix/missing_locales_dates_sk

Conversation

@AyakorK

@AyakorK AyakorK commented Jul 21, 2026

Copy link
Copy Markdown
Contributor

🎩 Description

On the Banska platform (sk locale), the admin datepicker displayed undefined in several places (help text, aria-labels, calendar close button), and in some cases blocked event creation/editing entirely (validation stuck on date fields).

The datepicker JS component (generate_datepicker.js / form_date_picker.js) fetches its translations via getDictionary() on the date.formats, time, and date.buttons keys. These keys were missing from sk.yml, so the JS received undefined instead of a string and rendered it as-is in the DOM.

Testing

  • Log in as admin on an organization with the sk locale active
  • Create or edit an event or assembly (any form with a date field)
  • Check that the help text under the datepicker shows readable text (no more undefined)
  • Open the calendar, check that the close button shows text instead of undefined
  • Pick a date and confirm it saves with the correct format (day/month not swapped)

Note: local reproduction is possible but kind of hard, since many other sk.yml keys are missing beyond the datepicker ones, there's no clean way to isolate just sk for testing. Testing was done by adding temporary locales that were deleted afterwards

📌 Related Issues

Tasks

  • Add missing locales

@AyakorK
AyakorK requested a review from moustachu July 21, 2026 15:21
@AyakorK
AyakorK marked this pull request as ready for review July 21, 2026 15:22
@AyakorK AyakorK changed the title fix: Add missing locales fix: Add missing locales on SK date picker Jul 21, 2026
@moustachu
moustachu merged commit ad303f2 into develop Jul 24, 2026
9 checks passed
@moustachu
moustachu deleted the fix/missing_locales_dates_sk branch July 24, 2026 08:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants