fix: Add missing locales on SK date picker - #1009
Merged
Merged
Conversation
AyakorK
marked this pull request as ready for review
July 21, 2026 15:22
moustachu
approved these changes
Jul 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎩 Description
On the Banska platform (
sklocale), the admin datepicker displayedundefinedin several places (help text, aria-labels, calendar close button), and in some cases blocked event creation/editing entirely (validation stuck on date fields).The datepicker JS component (
generate_datepicker.js/form_date_picker.js) fetches its translations viagetDictionary()on thedate.formats,time, anddate.buttonskeys. These keys were missing fromsk.yml, so the JS receivedundefinedinstead of a string and rendered it as-is in the DOM.Testing
sklocale activeundefined)undefinedNote: local reproduction is possible but kind of hard, since many other
sk.ymlkeys are missing beyond the datepicker ones, there's no clean way to isolate justskfor testing. Testing was done by adding temporary locales that were deleted afterwards📌 Related Issues
Tasks