Extension for Traffic Sign classification for better harmonisation with OpenDRIVE by MarcelOliver · Pull Request #482 · OpenSimulationInterface/open-simulation-interface

MarcelOliver · 2021-02-11T15:16:53Z

Add a description

OpenDRIVE categorization for traffic signs is more generic than OSI enum.
OpenDRIVE 1.6 definition for traffic sign:

Some questions to ask:
What is this change?
Extension for traffic sign classification (mainSign and sulpplementarySign). Adding attributes country, country_revision, code and sub_code in order to provide a better traffic sign harmonisation with OpenDRIVE.

Mention a member

@HendrikAmelunxen @pmai

Check the checklist

My code and comments follow the style guidelines and contributors guidelines of this project.
I have performed a self-review of my own code.
I have made corresponding changes to the documentation.
My changes generate no new warnings.
I have added tests that prove my fix is effective or that my feature works.
New and existing unit tests / travis ci pass locally with my changes.

HendrikAmelunxen

Approved; as discussed in OSI Harmonization working group

stefancyliax · 2021-03-31T09:29:47Z

OSI CCB:

verify the proto comments (styling) (Pierre)
documentation review: how should we mark deprecated parts of the code (Max)

HendrikAmelunxen · 2021-05-11T13:31:44Z

Harmonisation meeting: 11.05.21
Adaptations have to be carried out for Roadmarkings either.
=> 3.4 add additional attributes
=> 4.0 implement main traffic sign classification for road markings

… sign classification (mainSign and supplementarySign Signed-off-by: Marcel Sachse <msachse@pmsfit.de>

…, alpha-2 codes. Signed-off-by: Marcel Sachse <msachse@pmsfit.de>

Signed-off-by: Marcel Sachse <msachse@pmsfit.de>

…mirrored Signed-off-by: Marcel Sachse <msachse@pmsfit.de>

Signed-off-by: Marcel Sachse <msachse@pmsfit.de>

…king Signed-off-by: Marcel Sachse <msachse@pmsfit.de>

kmeids · 2021-05-26T09:23:02Z

Output from CCB 26.05.2021

@max-rosin please do a documentation review and set to ReadyForCCBReview when done.

max-rosin · 2021-06-25T12:45:03Z

osi_roadmarking.proto

-        // This can be achieved by visibly crossing the road marking with stripes, 
-        // or completly covering a road marking making it not visible. 
+        // This can be achieved by visibly crossing the road marking with stripes,
+        // or completly covering a road marking making it not visible.


Typo: "completely"...

max-rosin · 2021-06-25T12:47:06Z

osi_roadmarking.proto

        //
+        // \attention Deprecated: OpenDRIVE categorization for traffic signs is more generic than OSI enum
+        // (see <a href="https://releases.asam.net/OpenDRIVE/1.6.0/ASAM_OpenDRIVE_BS_V1-6-0.html#_signals">OpenDRIVE V1-6-0</a>).<br>
+        // How the Type will be dealt in future will be discussed in Harmonization OpenX group.<br>


Typo: "dealt with..."

max-rosin · 2021-06-25T12:48:02Z

osi_roadmarking.proto

+        // \attention Deprecated: OpenDRIVE categorization for traffic signs is more generic than OSI enum
+        // (see <a href="https://releases.asam.net/OpenDRIVE/1.6.0/ASAM_OpenDRIVE_BS_V1-6-0.html#_signals">OpenDRIVE V1-6-0</a>).<br>
+        // How the Type will be dealt in future will be discussed in Harmonization OpenX group.<br>
+        // Deprecated planned for version 4.0.0


Better: "Deprecation planned for..." or "Deprecated status planned for..."

max-rosin · 2021-06-25T12:48:09Z

osi_trafficsign.proto

+            // \attention Deprecated: OpenDRIVE categorization for traffic signs is more generic than OSI enum
+            // (see <a href="https://releases.asam.net/OpenDRIVE/1.6.0/ASAM_OpenDRIVE_BS_V1-6-0.html#_signals">OpenDRIVE V1-6-0</a>).<br>
+            // How the Type type will be dealt in future will be discussed in Harmonization OpenX group.<br>
+            // Deprecated planned for version 4.0.0


Better: "Deprecation planned for..." or "Deprecated status planned for..."

max-rosin · 2021-06-25T12:48:24Z

osi_trafficsign.proto

            //
+            // \attention Deprecated: OpenDRIVE categorization for traffic signs is more generic than OSI enum
+            // (see <a href="https://releases.asam.net/OpenDRIVE/1.6.0/ASAM_OpenDRIVE_BS_V1-6-0.html#_signals">OpenDRIVE V1-6-0</a>).<br>
+            // How the Type type will be dealt in future will be discussed in Harmonization OpenX group.<br>


Typo: "dealt with..."

max-rosin · 2021-06-25T12:51:54Z

osi_trafficsign.proto

            //
+            // \attention Deprecated: OpenDRIVE categorization for traffic signs is more generic than OSI enum
+            // (see <a href="https://releases.asam.net/OpenDRIVE/1.6.0/ASAM_OpenDRIVE_BS_V1-6-0.html#_signals">OpenDRIVE V1-6-0</a>).<br>
+            // How the Type will be dealt in future will be discussed in Harmonization OpenX group.<br>


Typo: "dealt with..."

max-rosin · 2021-06-25T12:52:03Z

osi_trafficsign.proto

            //
+            // \attention Deprecated: OpenDRIVE categorization for traffic signs is more generic than OSI enum
+            // (see <a href="https://releases.asam.net/OpenDRIVE/1.6.0/ASAM_OpenDRIVE_BS_V1-6-0.html#_signals">OpenDRIVE V1-6-0</a>).<br>
+            // How the bool vertically_mirrored will be dealt in future will be discussed in Harmonization OpenX group.<br>


Typo: "dealt with..."

max-rosin · 2021-06-25T12:52:11Z

osi_trafficsign.proto

            //
+            // \attention Deprecated: OpenDRIVE categorization for traffic signs is more generic than OSI enum
+            // (see <a href="https://releases.asam.net/OpenDRIVE/1.6.0/ASAM_OpenDRIVE_BS_V1-6-0.html#_signals">OpenDRIVE V1-6-0</a>).<br>
+            // How the DirectionScope direction_scope will be dealt in future will be discussed in Harmonization OpenX group.<br>


Typo: "dealt with..."

max-rosin · 2021-06-25T12:52:29Z

osi_trafficsign.proto

+            // \attention Deprecated: OpenDRIVE categorization for traffic signs is more generic than OSI enum
+            // (see <a href="https://releases.asam.net/OpenDRIVE/1.6.0/ASAM_OpenDRIVE_BS_V1-6-0.html#_signals">OpenDRIVE V1-6-0</a>).<br>
+            // How the DirectionScope direction_scope will be dealt in future will be discussed in Harmonization OpenX group.<br>
+            // Deprecated planned for version 4.0.0


Better: "Deprecation planned for..." or "Deprecated status planned for..."

max-rosin · 2021-06-25T12:52:39Z

osi_trafficsign.proto

+            // \attention Deprecated: OpenDRIVE categorization for traffic signs is more generic than OSI enum
+            // (see <a href="https://releases.asam.net/OpenDRIVE/1.6.0/ASAM_OpenDRIVE_BS_V1-6-0.html#_signals">OpenDRIVE V1-6-0</a>).<br>
+            // How the bool vertically_mirrored will be dealt in future will be discussed in Harmonization OpenX group.<br>
+            // Deprecated planned for version 4.0.0


Better: "Deprecation planned for..." or "Deprecated status planned for..."

Signed-off-by: Marcel Sachse <msachse@pmsfit.de>

ThomasNaderBMW · 2021-07-13T08:25:56Z

osi_roadmarking.proto

        //
+        // \attention Deprecated: OpenDRIVE categorization for traffic signs is more generic than OSI enum
+        // (see <a href="https://releases.asam.net/OpenDRIVE/1.6.0/ASAM_OpenDRIVE_BS_V1-6-0.html#_signals">OpenDRIVE V1-6-0</a>).<br>
+        // How the Type will be dealt with in future will be discussed in Harmonization OpenX group.<br>


in the future?

stefancyliax · 2021-07-13T08:30:11Z

CCB 13.07.2021:
Review in CCB:

Harmonization topic for "type" in relation to OpenDRIVE. Please add name of corresponding field in OpenDRIVE.
add general hint to OpenDRIVE
"Deprecated status planned for version 4.0.0" needs to be changed to "revision planned for version 4.0.0"
to be done by @pmai

Signed-off-by: Pierre R. Mai <pmai@pmsf.de>

kmeids · 2021-07-21T09:17:44Z

CCB Output 21.07.2021

@pmai will be able to merge this.

HendrikAmelunxen added the Harmonisation The Group in the ASAM development project working on harmonisation with other standards. label Feb 18, 2021

HendrikAmelunxen added the ReadyForCCBReview Indicates that this PR is ready for a final review and merge by the CCB. label Mar 25, 2021

HendrikAmelunxen approved these changes Mar 25, 2021

View reviewed changes

stefancyliax added Documentation Everything which impacts the quality of the documentation and guidelines. and removed ReadyForCCBReview Indicates that this PR is ready for a final review and merge by the CCB. labels Mar 31, 2021

thempen added the ReadyForCCBReview Indicates that this PR is ready for a final review and merge by the CCB. label May 18, 2021

MarcelOliver added 20 commits May 25, 2021 15:05

add attribute country, country_revision, code and sub_code to traffic…

2437594

… sign classification (mainSign and supplementarySign Signed-off-by: Marcel Sachse <msachse@pmsfit.de>

Use string for country type. For country specification see ISO 3166-1…

f076a8a

…, alpha-2 codes. Signed-off-by: Marcel Sachse <msachse@pmsfit.de>

mark possible deprecated messages

a303995

Signed-off-by: Marcel Sachse <msachse@pmsfit.de>

mark possible deprecated messages

e372f8b

Signed-off-by: Marcel Sachse <msachse@pmsfit.de>

Modified comment to mark as deprecated in a uniform way - enum actor

238bba6

Signed-off-by: Marcel Sachse <msachse@pmsfit.de>

Modified comment to mark as deprecated in a uniform way - enum Direction

30eae41

Signed-off-by: Marcel Sachse <msachse@pmsfit.de>

Modified comment to mark as deprecated in a uniform way - type

b0d492b

Signed-off-by: Marcel Sachse <msachse@pmsfit.de>

Modified comment to mark as deprecated in a uniform way - DirectionScope

592e63b

Signed-off-by: Marcel Sachse <msachse@pmsfit.de>

Modified comment to mark as deprecated in a uniform way - vertically_…

178331d

…mirrored Signed-off-by: Marcel Sachse <msachse@pmsfit.de>

Modified comment to mark as deprecated in a uniform way - Type

461b62e

Signed-off-by: Marcel Sachse <msachse@pmsfit.de>

Modified comment to mark as deprecated in a uniform way - Type type

5c8c16c

Signed-off-by: Marcel Sachse <msachse@pmsfit.de>

Modified comment to mark as deprecated in a uniform way - Actor actor

87c76cd

Signed-off-by: Marcel Sachse <msachse@pmsfit.de>

Modified comment to mark as deprecated in a uniform way - Arrow arrow

0510587

Signed-off-by: Marcel Sachse <msachse@pmsfit.de>

Modified comment to mark as deprecated in a uniform way - Type

accd114

Signed-off-by: Marcel Sachse <msachse@pmsfit.de>

Modified comment to mark as deprecated in a uniform way

0403989

Signed-off-by: Marcel Sachse <msachse@pmsfit.de>

add examples for country and country_revision in comment

088386c

Signed-off-by: Marcel Sachse <msachse@pmsfit.de>

correct example for ISO 3166-1 alpha-2 code

2130d2b

Signed-off-by: Marcel Sachse <msachse@pmsfit.de>

better comments to clarify use of code and sub_code

25e9638

Signed-off-by: Marcel Sachse <msachse@pmsfit.de>

mark Type as deprecated

545a96e

Signed-off-by: Marcel Sachse <msachse@pmsfit.de>

add attribute country, country_revision, code and sub_code to roadmar…

c75aa0f

…king Signed-off-by: Marcel Sachse <msachse@pmsfit.de>

MarcelOliver force-pushed the extension/traffic-sign-classification branch from f908890 to c75aa0f Compare May 25, 2021 13:05

kmeids removed the ReadyForCCBReview Indicates that this PR is ready for a final review and merge by the CCB. label May 26, 2021

pmai added this to the V3.4.0 milestone Jun 23, 2021

max-rosin suggested changes Jun 25, 2021

View reviewed changes

MarcelOliver requested a review from max-rosin June 29, 2021 12:36

Documentation Update (fix typo + better wording)

df50fbb

Signed-off-by: Marcel Sachse <msachse@pmsfit.de>

MarcelOliver force-pushed the extension/traffic-sign-classification branch from 4b35b2f to df50fbb Compare June 29, 2021 13:08

max-rosin approved these changes Jul 1, 2021

View reviewed changes

HendrikAmelunxen added the ReadyForCCBReview Indicates that this PR is ready for a final review and merge by the CCB. label Jul 7, 2021

ThomasNaderBMW reviewed Jul 13, 2021

View reviewed changes

Refer to OpenDRIVE, clarify deprecation intent

6fd1bec

Signed-off-by: Pierre R. Mai <pmai@pmsf.de>

pmai force-pushed the extension/traffic-sign-classification branch from c956d8d to 6fd1bec Compare July 13, 2021 11:24

Merge branch 'master' into extension/traffic-sign-classification

3f95b59

kmeids added ReadyToMerge This PR has been approved to merge and will be merged by a member of the CCB. and removed ReadyForCCBReview Indicates that this PR is ready for a final review and merge by the CCB. labels Jul 21, 2021

pmai merged commit 3ad5c67 into OpenSimulationInterface:master Jul 21, 2021

Conversation

MarcelOliver commented Feb 11, 2021

Add a description

Mention a member

Check the checklist

Uh oh!

HendrikAmelunxen left a comment

Choose a reason for hiding this comment

Uh oh!

stefancyliax commented Mar 31, 2021

Uh oh!

HendrikAmelunxen commented May 11, 2021

Uh oh!

kmeids commented May 26, 2021

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

stefancyliax commented Jul 13, 2021

Uh oh!

kmeids commented Jul 21, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants