fix(docs): corrected vector from rear axis to sensor mounting point#456
Merged
stefancyliax merged 6 commits intomasterfrom Oct 29, 2021
Merged
Conversation
Signed-off-by: Katrin Mehl <katrin.mehl@parson-europe.com>
Contributor
Author
|
update of svg after input from ccb. Please have a look if this fits now: A description about bbcenter_to_rear is documented here Which I used for naming the end of the vector from center of the bounding box to the rear axle. |
Signed-off-by: Katrin Mehl <katrin.mehl@parson-europe.com>
Signed-off-by: Katrin Mehl <katrin.mehl@parson-europe.com>
Signed-off-by: Katrin Mehl <katrin.mehl@parson-europe.com>
stefancyliax
approved these changes
Oct 29, 2021
Contributor
stefancyliax
left a comment
There was a problem hiding this comment.
Image was approved in the SensorModelling WG meeting 29.10.2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Reference to a related issue in the repository
#447
Add a description
Changed the start of vector pointing to the physical mounting position of the sensor.
It was: Center of the bounding box.
It is: Middle of the rear axis (coordinate system).
It is a bug fix according to the related issue.
It shall enhance the understanding of MovingObjects and the related coordinate systems.
It has not been tested. But since this is only an svg not code-related, no testing is needed.
Hence, I don't think it will break any existing functionality or force me to update to a new version.
Mention a member
@HendrikAmelunxen please reviewing proposed changes.
Check the checklist