Read tetrahedron volume - #75
Open
Alberto-o wants to merge 11 commits into
Open
Conversation
… needed, use volumeGroups instead
…s function to convert to relativeCoordinates
Alberto-o
marked this pull request as ready for review
July 28, 2026 11:49
Collaborator
Author
|
Major changes:
To avoid having cases where the exterior of the geometry is returned by Filler, and cases where it isn't, a FillingMode has been added, to selectively return the exterior. It is needed for tetrahedron meshes, but not needed for triangle meshes Filled volume meshes have been added for staircased meshes only at this point |
lmdiazangulo
requested changes
Jul 30, 2026
Contributor
There was a problem hiding this comment.
I think we are having a war on versions on this file... which is very user dependent. I think we should remove it and add it to .gitignore.
lmdiazangulo
requested changes
Jul 30, 2026
| target_link_libraries(tessellator-core | ||
| tessellator-utils | ||
| tessellator-cgal | ||
| CGAL::CGAL) No newline at end of file |
Contributor
There was a problem hiding this comment.
CGAL was optional. Is it required for volumes?
Collaborator
Author
There was a problem hiding this comment.
I'm afraid so. To have the volumes filled Filler is used, and it uses CGAL
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.