Skip to content

Changes arguments passed by value to reference #74

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Alberto-o merged 1 commit into from
Jul 24, 2026
Merged

Changes arguments passed by value to reference #74

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/core/Staircaser.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -448,7 +448,7 @@ bool Staircaser::isAllCoordinatesOnTheSameCellBoundary(const Element& newElement
return !commonStructuredCells.empty();
}

std::set<Element> Staircaser::getElementsConvertedInLines(Cell cell, std::map<Cell, std::vector<const Element*>> cellElemMap) {
std::set<Element> Staircaser::getElementsConvertedInLines(const Cell cell, const std::map<Cell, std::vector<const Element*>>& cellElemMap) {
std::set<Element> elementsConvertedInLines;

for (const auto& e : cellElemMap.at(cell)) {
Expand Down Expand Up @@ -492,7 +492,7 @@ std::set<Element> Staircaser::getElementsConvertedInLines(Cell cell, std::map<Ce
return elementsConvertedInLines;
}

void Staircaser::splitLinesWithNeighborTriangle(const size_t groupIndex, std::set<Element> elementsConvertedInLines, Group& meshGroup, const Cell cell, std::map<Cell, std::vector<const Element*>> cellElemMap, std::vector<std::set<ElementId>> toRemove) {
void Staircaser::splitLinesWithNeighborTriangle(const size_t groupIndex, std::set<Element> elementsConvertedInLines, Group& meshGroup, const Cell cell, const std::map<Cell, std::vector<const Element*>>& cellElemMap, std::vector<std::set<ElementId>> toRemove) {
for (const auto& e: elementsConvertedInLines) {
bool processed = false;
for (const auto& otherElementsInCell: cellElemMap.at(cell)) {
Expand Down
6 changes: 4 additions & 2 deletions src/core/Staircaser.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,10 +78,12 @@ class Staircaser : public utils::GridTools {
void fillGaps(const RelativePairSet boundaryCoordinatePairs);
std::pair<Element, Relatives> obtainNewIndexForElement(const Element& e, const std::set<Cell>& cellsToStructure, CoordinateMap& coordinateMap);
bool isAllCoordinatesOnTheSameCellBoundary(const Element& newElement, const std::set<Cell>& cellsToStructure);
std::set<Element> getElementsConvertedInLines(const Cell cell, std::map<Cell, std::vector<const Element*>> cellElemMap);
void splitLinesWithNeighborTriangle(const size_t groupIndex, std::set<Element> elementsConvertedInLines, Group& meshGroup, const Cell cell, std::map<Cell, std::vector<const Element*>> cellElemMap, std::vector<std::set<ElementId>> toRemove);
std::set<Element> getElementsConvertedInLines(const Cell cell, const std::map<Cell, std::vector<const Element*>>& cellElemMap);
void splitLinesWithNeighborTriangle(const size_t groupIndex, std::set<Element> elementsConvertedInLines, Group& meshGroup, const Cell cell, const std::map<Cell, std::vector<const Element*>>& cellElemMap, std::vector<std::set<ElementId>> toRemove);
};




}
}
Loading