Skip to content

Volume meshing - #71

Merged
carlosgonzalez-elemwave merged 8 commits into
devfrom
feature/volume_mesh
Jul 15, 2026
Merged

Volume meshing#71
carlosgonzalez-elemwave merged 8 commits into
devfrom
feature/volume_mesh

Conversation

@Alberto-o

Copy link
Copy Markdown
Collaborator

No description provided.

@Alberto-o Alberto-o changed the title Adds MesherBase options to have stair and conf options derived from it. Adds bool isVolume to options Volume meshing Jun 9, 2026
@Alberto-o
Alberto-o requested a review from lmdiazangulo June 9, 2026 14:16
@Alberto-o

Copy link
Copy Markdown
Collaborator Author

Initially I wanted to make "isVolume" a property of the mesh, and not of the options. However, the mesh is passed as an arguments a lot of times, and I thought that having to copy a new property when creating derived meshes was error-prone. Options are not modified after being passed to the mesher, and there the flag for volume filling is conserved along the process

@Alberto-o

Copy link
Copy Markdown
Collaborator Author

Additionally: I see there is the option "volumeGroups". However, the StaircaseMesher seems to be meant to work with a surface mesh as input. I have preferred keeping the mesher initialization almost the same, and instead checking during the "process" step whether the body should be treated as a volume

@Alberto-o

Copy link
Copy Markdown
Collaborator Author

@copilot check the action log and propose a solution to fix the vcpkg related compilation issue

Copilot AI commented Jun 9, 2026

Copy link
Copy Markdown

@copilot check the action log and propose a solution to fix the vcpkg related compilation issue

I checked the failed Actions runs (dev had no relevant failures; feature/volume_mesh failed in all build matrix jobs). Root cause was vcpkg trying to use the GHA binary source (x-gha) and failing with missing ACTIONS_RUNTIME_TOKEN / ACTIONS_CACHE_URL during vcpkg install. I fixed it in commit 3c8ff72 by setting VCPKG_BINARY_SOURCES: clear at job level in .github/workflows/build-and-test.yml, which disables the GHA binary source and lets configure proceed.

@Alberto-o

Copy link
Copy Markdown
Collaborator Author

MIssing: test counting elements and checking there are more quads than w/o volume filling, and there no triangles, i.e., the volume is correctly filled

@Alberto-o
Alberto-o marked this pull request as ready for review June 10, 2026 08:45
@carlosgonzalez-elemwave carlosgonzalez-elemwave linked an issue Jul 13, 2026 that may be closed by this pull request
@carlosgonzalez-elemwave

Copy link
Copy Markdown
Collaborator

Wait for PR #73 and rebase before merging.

@carlosgonzalez-elemwave
carlosgonzalez-elemwave merged commit c2179c9 into dev Jul 15, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Manage volume meshes

4 participants