Skip to content

Add compressor functionality to the tessellator - #68

Merged
lmdiazangulo merged 20 commits into
devfrom
adds-compressor
Jul 21, 2026
Merged

Add compressor functionality to the tessellator#68
lmdiazangulo merged 20 commits into
devfrom
adds-compressor

Conversation

@lmdiazangulo

@lmdiazangulo lmdiazangulo commented May 8, 2026

Copy link
Copy Markdown
Contributor
  • Implemented Compressor class for merging coplanar quad surfaces.
  • Updated StaircaseMesher to include compression option.
  • Enhanced launcher to read compression settings from JSON input.
  • Added tests for Compressor functionality.

@lmdiazangulo

lmdiazangulo commented May 16, 2026

Copy link
Copy Markdown
Contributor Author

@copilot fix this so the actions pass

Copilot AI commented May 16, 2026

Copy link
Copy Markdown

@copilot fix this so the actions pass

Addressed in 1742a94 (plus f95e55f): I updated the CI workflow to disable the vcpkg GHA binary source during configure/build and added explicit minimal GITHUB_TOKEN permissions (contents: read) so the Actions security check also passes.

@lmdiazangulo lmdiazangulo changed the title Add compressor functionality to the tessellator [WIP] Add compressor functionality to the tessellator May 16, 2026
@lmdiazangulo
lmdiazangulo marked this pull request as draft May 16, 2026 11:00
@lmdiazangulo

lmdiazangulo commented May 17, 2026

Copy link
Copy Markdown
Contributor Author

@copilot can you check what is wrong with the failing action and fix it?

Copilot AI commented May 17, 2026

Copy link
Copy Markdown

@copilot can you check what is wrong with the failing action and fix it?

Fixed in b3b9b63. The failure was a transient vcpkg dependency download error on Windows (status code 502 while fetching Boost). I added retries to the configure step (Windows and Ubuntu) so transient download/network issues don’t fail the whole action immediately.

@lmdiazangulo lmdiazangulo changed the title [WIP] Add compressor functionality to the tessellator Add compressor functionality to the tessellator May 18, 2026
@lmdiazangulo
lmdiazangulo marked this pull request as ready for review May 18, 2026 08:37
carlosgonzalez-elemwave
carlosgonzalez-elemwave reviewed May 19, 2026
View reviewed changes
Comment thread .vscode/launch.json Outdated
Comment thread src/app/launcher.cpp
Comment thread test/core/CompressorTest.cpp Outdated
Comment thread test/core/CompressorTest.cpp
Comment thread test/core/CompressorTest.cpp Outdated
Comment thread src/core/Splitter.cpp Outdated
Comment thread src/core/Splitter.cpp Outdated
Comment thread src/core/Compressor.cpp Outdated
Comment thread src/core/Compressor.cpp
Comment thread src/meshers/StaircaseMesher.cpp Outdated
@lmdiazangulo lmdiazangulo self-assigned this May 21, 2026
@lmdiazangulo lmdiazangulo mentioned this pull request May 21, 2026
Open
@lmdiazangulo
lmdiazangulo marked this pull request as draft June 9, 2026 12:46
@carlosgonzalez-elemwave
carlosgonzalez-elemwave force-pushed the adds-compressor branch 2 times, most recently from 55f152b to 6f76a97 Compare July 16, 2026 11:54
@carlosgonzalez-elemwave

carlosgonzalez-elemwave commented Jul 16, 2026

Copy link
Copy Markdown
Collaborator

The cmake conditions that relied on VTK_FOUND had the problem of not importing their respective tests. Adding that it also prevented lots of otherwise perfectly runnable tests to be run independently, I refactored the workflow to use global pre-compiled flags.

The new flag APP_LOADED is only true if the application code has been successfully configured, and can be accessed anywhere in the project without any #includes. Tests that require to load a file or use the launcher now compile independently if the flag is true, allowing all other tests to run even if the application has not been compiled.

@carlosgonzalez-elemwave

carlosgonzalez-elemwave commented Jul 16, 2026

Copy link
Copy Markdown
Collaborator

I have deleted the Splitter class. It has several fundamental errors and it's not used outside of compressor tests. If a necessity for a splitter comes around, it can be recovered from these commits and fix, or make it from scratch.

@carlosgonzalez-elemwave
carlosgonzalez-elemwave force-pushed the adds-compressor branch 3 times, most recently from 4e467d3 to 265f698 Compare July 20, 2026 07:25
@lmdiazangulo @carlosgonzalez-elemwave
Add compressor functionality to the tessellator
d2ec255 
- Implemented Compressor class for merging coplanar quad surfaces.
- Updated StaircaseMesher to include compression option.
- Enhanced launcher to read compression settings from JSON input.
- Added tests for Compressor functionality.
@lmdiazangulo @carlosgonzalez-elemwave
Fix compressor test crash and element removal
cad1b5c 
- Add groups initialization check in addQuad() helper to prevent segfault
- Fix compressSurfaces() to properly remove merged elements
- Update test expectations for merged return value
@lmdiazangulo @carlosgonzalez-elemwave
Adds IDE configuration files
0013e88
@lmdiazangulo @carlosgonzalez-elemwave
Compressor not working
43c6e77
@lmdiazangulo @carlosgonzalez-elemwave
Iterating
0573325
lmdiazangulo and others added 15 commits July 20, 2026 10:26
@lmdiazangulo @carlosgonzalez-elemwave
More tests and splitter
3bc4439
@lmdiazangulo @carlosgonzalez-elemwave
tesrs pass
1538acd
@lmdiazangulo @carlosgonzalez-elemwave
Surface compressor works!
132d5d4
@lmdiazangulo @carlosgonzalez-elemwave
Adds compress lines
12bc295
@lmdiazangulo @carlosgonzalez-elemwave
Adds comoressor abf exportGrid options
1129486
@lmdiazangulo @carlosgonzalez-elemwave
ci: retry configure step on transient vcpkg download failures
65d207a 
Agent-Logs-Url: https://github.com/OpenSEMBA/tessellator/sessions/e5974172-7eed-4d3b-a308-0d68b508b8c4

Co-authored-by: lmdiazangulo <4919398+lmdiazangulo@users.noreply.github.com>
@carlosgonzalez-elemwave
Tessellator | Build | Fix VTK import checks to allow tests that don't…
0e459a4 
… require it and import all of them when available
@carlosgonzalez-elemwave
Tessellator | Docker | Update linter and build for development contai…
69a330c 
…ners
@carlosgonzalez-elemwave
Tessellator | Core | Delete Splitter
ca8a8f6 
Splitter has several fundamental errors and it's not used outside of compressor tests. If a necessity for a splitter comes around, it can be recovered from these commits and fix, or make it from scratch.
@carlosgonzalez-elemwave
Tessellator | Testing | Update and fix compressor tests
c45947b
@carlosgonzalez-elemwave
Tessellator | Core | Refactor Compressor for better readability
f510332
@carlosgonzalez-elemwave
Tessellator | Testing | Update staircase mesher tests to include comp…
4a8a599 
…ression
@carlosgonzalez-elemwave
Tessellator | Testing | Tests for launcher with compression option
8a68199
@carlosgonzalez-elemwave
Tessellator | Core | Prevent polyline groups from being compressed
fa3db5a
@carlosgonzalez-elemwave
Tessellator | Mesher | Add the compress boolean into the staircaser m…
083e0ff 
…eshing options
@carlosgonzalez-elemwave
carlosgonzalez-elemwave marked this pull request as ready for review July 20, 2026 14:10
@lmdiazangulo
lmdiazangulo merged commit f2a45f4 into dev Jul 21, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@carlosgonzalez-elemwave carlosgonzalez-elemwave carlosgonzalez-elemwave left review comments

Assignees

@lmdiazangulo lmdiazangulo

@carlosgonzalez-elemwave carlosgonzalez-elemwave

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@lmdiazangulo @carlosgonzalez-elemwave