Skip to content

chore: document why .speakeasy/workflow.yaml keeps npm token placeholder - #1268

Open
alexb-openrouter wants to merge 1 commit into
mainfrom
devin/1793079264-npm-token-comment
Open

alexb-openrouter wants to merge 1 commit into
mainfrom
devin/1793079264-npm-token-comment

Conversation

@alexb-openrouter

Copy link
Copy Markdown
Contributor

Summary

Follow-up to #1267, from Perry's review there. Adds a comment only. Nothing changes at runtime.

targets.openrouter.publish.npm.token: $npm_token now looks dead, because NPM_TOKEN is no longer passed. But it is what turns publishing on. sdk-gen-config does not expand $npm_token, and Publishing.IsPublished("typescript") returns true only when NPM.Token != "". That makes the Speakeasy release step emit publish_typescript=true, which is what runs publish-npm. If the line is deleted, npm publishing is skipped silently and the Publish workflow still reports success. npm itself authenticates through trusted publishing (OIDC).

Unverified: whether a later Speakeasy CLI rewrite of workflow.yaml (for example a speakeasyVersion bump) keeps YAML comments.

Searched existing PRs; none matched.

Link to Devin session: https://openrouter.devinenterprise.com/sessions/ab9f8df32f544a1eae4412b551a5f4b4
Open in Devin Desktop: https://openrouter.devinenterprise.com/desktop/session/ab9f8df32f544a1eae4412b551a5f4b4?variant=devin
Requested by: @alexb-openrouter

@devin-ai-integration

Copy link
Copy Markdown
Contributor

I'll fix CI failures and address comments from users with write access that start with 'Devin'.

  • Disable automatic comment, CI, and merge conflict monitoring

Original prompt from Alex

SYSTEM:
<latest_message>
Alex Bujduveanu (U0BFFJD2XR8) [ts=1793074025.888729]: can this change be done entirely in a PR without git config chnages outside the PR?

publish tokens are long-lived. release.yaml publishes to npm with NPM_TOKEN, typescript-sdk uses NPM_TOKEN, python-sdk uses PYPI_TOKEN. litellm got hit in March because a token like this was readable from shared CI. fix: npm/PyPI trusted publishing (OIDC). ai-sdk-provider already does this.
</latest_message>

=== BEGIN THREAD HISTORY ===
Alex Bujduveanu (U0BFFJD2XR8) [ts=1793074025.888729]: can this change be done entirely in a PR without git config chnages outside the PR?

publish tokens are long-lived. release.yaml publishes to npm with NPM_TOKEN, typescript-sdk uses NPM_TOKEN, python-sdk uses PYPI_TOKEN. litellm got hit in March because a token like this was readable from shared CI. fix: npm/PyPI trusted publishing (OIDC). ai-sdk-provider already does this.
=== END THREAD HISTORY ===
Channel ID: D0BFEN3DLHK
Thread URL: https://openrouter.slack.com/archives/D0BFEN3DLHK/p1793074025888729?thread_ts=1793074025.888729&amp;cid=D0BFEN3DLHK

The <latest_message> is the message that you should use to guide your goals + task for this session, and you should use the rest of the slack thread as context.
A [ts=...] marker on a Slack message is that message's timestamp. To act on a specific message with the slack tool (e.g. adding an emoji reaction via the reaction command), pass that value as timestamp along with the Channel ID — no extra lookup call is needed.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant