fix: match .editorconfig to actual practice#2259
Open
brunom wants to merge 1 commit into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the repository’s .editorconfig C# newline/brace formatting rules with the stated goal of aligning Visual Studio formatting behavior with existing code so that formatting does not introduce diffs.
Changes:
- Switches several C# “new line preferences” settings (open braces,
catch/else/finally, and initializer member layout) to new-line style defaults.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+133
to
+138
| csharp_new_line_before_open_brace = all | ||
| csharp_new_line_before_catch = true | ||
| csharp_new_line_before_else = true | ||
| csharp_new_line_before_finally = true | ||
| csharp_new_line_before_members_in_anonymous_types = true | ||
| csharp_new_line_before_members_in_object_initializers = true |
Member
|
@brunom would not this break the java style code blocks used in all files ? |
Contributor
Author
|
I found out .editorconfig didn't match DisassemblyViewModel.cs while fixing #2260 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Now Visual Studio formatting leaves files unchanged. Tested on src/Spice86/ViewModels/DisassemblyViewModel.cs