Skip to content

ci: run the required dev checks on merge groups - #10

Open
Brad-Edwards wants to merge 1 commit into
devfrom
9-merge-group-checks
Open

Brad-Edwards wants to merge 1 commit into
devfrom
9-merge-group-checks

Conversation

@Brad-Edwards

Copy link
Copy Markdown
Contributor

Closes #9

Change

  • The CI workflow runs on the merge_group event (checks_requested).
  • verify uses the merge group base SHA as the comparison base on merge groups.
  • title-guard and body-guard run on pull requests and on merge groups.
  • On a merge group, each guard reads the queued pull request from the API. It parses the number from the queue ref and fails if the ref does not match. It also fails if the pull request does not target dev.
  • Each guard writes the title or body to a file and checks that file. The checks use the same patterns as before. No untrusted text goes into the shell.

Verification

  • actionlint (with shellcheck) passes on .github/workflows/ci.yml.
  • git diff --check passes.
  • A local run of the guard steps with a sample pull_request event passes. The queue ref pattern accepts a dev queue ref and rejects other refs.
  • CI on this pull request runs the changed guards on the pull_request event.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant