Repository navigation
feat: port experiment contracts and trial compilation to Go - #2063
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds native Go experiment validation, deterministic trial compilation and realization, and experiment, study, and trial records for issue #1788. Reference cases check exact plan identities, integrity digests, random draws, replacement lineage, and record publication.
Runtime execution and storage use required shared-owner interfaces. The implementation declares the runtime-owned package for mechanical extraction by #1894; it does not introduce a second engine, store, backend, or worker.
Requirement UIDs
Related Issues
Closes #1788
ADR Impact
docs/decisions/issue-1788-experiments-design.md.Changes
ControlContextProviderandOwnerCaller.Test Plan
Local verification passed:
TestFullValidationGoldenCorpus: 110 selected experiment/trial cases passed.TestCorpus/mcp_experiment_validate: six unchanged command goldens passed, including all three experiment examples.TestModelRulesMatchTheReferenceModelspasses with ten additional Python-validated run-plan and capture-selector vectors; all 554 prior vectors are preserved.golangci-lint run: zero issues. Actualarchcheck: no findings. The nine changed documents and the updated verification note passednox -s docs-prose -- <paths>. Three targeted Go workflow invariant cases passed. All 38 product packages occur exactly once across the six test groups.pre-commit run, the file-local staged repository policy check, and targeted Ruff checks passed.Final CI run passes on
9c6b2a9d19a2b94b7f3ef3ee692e137f72e2d104. The Go product coverage gate reports 90.0%. Sonar's quality gate passes with zero new issues, 83.4% new-code coverage, and 0.2% new-code duplication. All race groups and the public and container bootstrap checks pass.Full test, integration, fuzz, coverage, and mutation suites run in CI only. This PR run did not request the opt-in exhaustive Go mutation sweep. The scanner regression test is marked integration and is left to CI. The source inventory, case mapping, owner-boundary limitations, and defect-case evidence are recorded in
docs/decisions/issue-1788-experiments-verification.mdandimplementations/go/processor/trial/testdata/reference-case-map.json.Ground Control Checks
The automated pre-push review did not produce a verdict after two 20-minute timeouts. The user explicitly directed manual continuation without the Ground Control workflow. This PR makes no completed-review attestation.
Traceability
implementations/go/contract/admission,implementations/go/processor/trial,implementations/go/runtime/experiment, andimplementations/tooling/go/arch/api_files.go.implementations/go/processor/trial/testdata/reference-case-map.json, andimplementations/tooling/go/arch/api_files_test.go.Checklist
Documentation
Updated the experiment design, preflight inventory, verification record, approved validator-key decision, architecture ownership and API declarations, Go architecture guide, and MOD-001 traceability. The verification note follows the repository guide and the doc-tools v0.1.0 documentation skill.