Skip to content

ci: add the merge-queue removal label workflow - #2056

Merged
Brad-Edwards merged 7 commits into
devfrom
2052-merge-queue-removed-workflow
Nov 15, 2026
Merged

Brad-Edwards merged 7 commits into
devfrom
2052-merge-queue-removed-workflow

Conversation

@Brad-Edwards

@Brad-Edwards Brad-Edwards commented Nov 15, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

Adds the Ground Control Merge Queue Removed workflow. When the dev merge queue removes an open pull request without a merge, the workflow adds the merge-queue-removed label. It removes the label when the pull request enters the queue again or closes. The action policy rejects a write token on a pull_request job, so this change adds a reviewed boundary that admits pull-requests: write only for this exact job shape.

Requirement UIDs

  • (none — bug/refactor/maintenance run; see Traceability section below)

Related Issues

Closes #2052

ADR Impact

  • No ADR required

Changes

  • Add .github/workflows/merge-queue-removed.yml from Ground Control. The job holds only pull-requests: write. An issues: write token got HTTP 403 when it added the label.
  • Add _queue_label_boundary to tools/tooling_artifact_policy_actions.py. It admits pull-requests write only for the label job in this workflow, with queue events only, no uses step, no container, no secret, and the ubuntu-latest runner.
  • Add the job to the reviewed write scopes and the trigger checks in test_release_workflows.py.
  • Add test_issue_2052_merge_queue_label.py for the workflow shape and the boundary limits.
  • Give test_completed_replacement_publishes_accounting_and_exact_scientific_versions explicit 10000 ms supervision budgets. Its study validation reads 16 runs in one observation call, which went over the 2000 ms default on a loaded merge-group runner.
  • Describe the label in docs/DEVELOPMENT_WORKFLOW.md.

Test Plan

  • Unit tests pass
  • Integration tests pass if applicable
  • Full completion suite required in CI before merge
  • No coverage regression

Targeted: test_issue_2052_merge_queue_label.py, test_issue_1313_workflow_policy.py, test_issue_2026_merge_queue.py, the two changed tests in test_release_workflows.py, and the changed test in test_issue_1630_record_recovery.py. A 50 ms observation budget reproduced the merge-group failure exactly.

Ground Control Checks

  • Repository policy checks required in CI before merge
  • Pre-push Codex review not run for this lane; CI and repository policy gates enforced

Traceability

  • IMPLEMENTS: (none — bug/refactor/maintenance run)
  • TESTS: (none — documentation/configuration/structural-invariant run)

Checklist

  • Code follows the project's coding standards
  • Changelog: owned by Release Please (generated from the Conventional Commit PR title; no per-PR fragment)
  • Architectural docs updated if stack, package structure, or key behaviors changed

Documentation

Updated: see diff.

@Brad-Edwards
Brad-Edwards added this pull request to the merge queue Nov 15, 2026
@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Nov 15, 2026
@Brad-Edwards
Brad-Edwards added this pull request to the merge queue Nov 15, 2026
Merged via the queue into dev with commit 1f4d05e Nov 15, 2026
44 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant