Repository navigation
fix(guacamole): queue identity token requests instead of refusing them - #2989
Merged
Merged
Conversation
GoogleGatewayIdentity ran token requests on one thread with a queue of one. A third concurrent caller was refused at once with RejectedExecutionException. Each authority renewal asks for the token, so with 16 renewal workers most renewals failed. The leases expired and Guacamole closed sessions 90 to 150 seconds after sign-in. On the live event tenant this logged participants out every two to five minutes. Set the queue capacity to 64, above the renewal worker count. Callers wait for the cached token instead of being refused, and each caller still stops waiting after three seconds. Add a test that 32 concurrent callers all receive the assertion.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
GoogleGatewayIdentitygets the Google identity token on one thread with a queue of one. A third concurrent caller is refused at once withRejectedExecutionException.Each authority renewal asks for the token. With 16 renewal workers (#2985), most renewals failed. The leases expired, and Guacamole closed the sessions 90 to 150 seconds after sign-in.
On the live event tenant on 2026-11-19, a 45-second Java Flight Recorder capture showed 529 refused token requests in the renewal threads. Participants were logged out every two to five minutes. The portal authority endpoint answered
{"allowed": true}for the same sessions.Change
Live status
The same extension build runs on the live event tenant since 18:33 UTC.
Verification
mvn verifyinshifter/engine/guacamole/authority-extension, with the Dockerfile test list, passes.