Repository navigation
fix(ctf): show a teammate's solve on the challenge list and detail - #2987
Merged
Merged
Conversation
In team mode a teammate's correct flag counts once for the team score, but the challenge list and detail showed it as unsolved for the other members. Add team_solved to both participant projections. The pages show it as "Solved by your team" and keep the flag form, so a member can still submit for the individual score.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
In a team-mode event, a teammate's correct flag counts once for the team score. The challenge list and the challenge detail page set
solvedonly from the participant's own submissions. The other team members saw the challenge as unsolved, also after a reload.Change
ctf/api/projections.py: addteam_solvedto the participant challenge list and detail. It is true when any member of the participant's team has a correct submission for the challenge. It is always false outside team mode or for a participant without a team.openapi/v1.json,frontend/src/api/schema.d.ts: the new field.ChallengesPageandChallengeDetailPage: show a team solve as "Solved by your team". The detail page keeps the flag form, because the individual score counts only the participant's own solves.Verification
tests/ctf/test_participant_api.pypasses, with two new tests (teammate solve, solo event).ChallengesPage.test.tsxandChallengeDetailPage.test.tsxpass, with two new tests.tsc --noEmit, eslint, ruff check, and ruff format pass on the changed files.