Repository navigation
fix(guacd): build guacd 1.6.1 and allow 15 minutes of client silence - #2986
Merged
Merged
Conversation
guacd 1.6.0 aborts RDP connections about five seconds after connect on an assertion in guac_display_remove_layer() (display-layer-list.c:327). On the live event tenant this ended about 8% of new RDP sessions, and some participants hit it on every retry. Upstream fixed the race in GUACAMOLE-2234 and GUACAMOLE-2118 on the staging/1.6.1 branch. No released guacd image contains the fixes. Build guacd from the upstream Dockerfile at commit 59fa92bf, with these changes: - Fetch the source from the pinned upstream commit. - Pin libssh2 1.11, LibVNCServer 0.9.15 and libwebsockets 4.3, as in the guacd 1.6.0 image. The latest libwebsockets (v5.1.0) does not build. - Pin the Alpine 3.18 base image by digest. - Keep the RDP drive directory and the health check.
guacd ends a connection when the browser sends nothing for GUACD_TIMEOUT, which upstream sets to 15 seconds. Browsers slow the keep-alive in background tabs, so participants lost RDP and SSH sessions when they switched tabs. On the live event tenant this was the most common reason a session ended. Set GUACD_TIMEOUT to 900000 ms (15 minutes) at build time. A connection whose browser is gone now stays open for up to 15 minutes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
guacd 1.6.0 aborts RDP connections about five seconds after connect:
On the live event tenant, this ended about 8% of new RDP sessions (40 crashes from 14:50 to 15:45 UTC on 2026-11-19). Some participants hit it on every retry. Upstream fixed this race on the
staging/1.6.1branch (GUACAMOLE-2234 and GUACAMOLE-2118). No released guacd image contains the fixes.guacd ends a connection when the browser sends nothing for 15 seconds (
GUACD_TIMEOUT). Browsers slow the keep-alive in background tabs, so participants lost RDP and SSH sessions when they switched tabs. On the live tenant this was the most common reason a session ended.Change
shifter/engine/guacd/Dockerfilenow builds guacd from the upstream Dockerfile at commit59fa92bfc8bd6df4f0392fe99dfc78b0a0457cc7(staging/1.6.1), with these changes:GUACD_TIMEOUTto 900000 ms (15 minutes). A connection whose browser is gone now stays open for up to 15 minutes.Return to an upstream release image when guacd 1.6.1 is released, and keep the timeout change.
Live status
The same build is running on the live event tenant since 15:55 UTC (
guacd@sha256:6b5d5f5a…). This PR keeps the next Helm upgrade from returning guacd to 1.6.0.Verification
docker build --check shifter/engine/guacd: no warnings.trivy config --exit-code 1 shifter/engine/guacd: 0 findings.#define GUACD_TIMEOUT 900000._quality.ymlruntime test steps pass locally: non-root user, drive directory mode 750, and guacd listens on 4822 with a read-only root and no capabilities.