Skip to content

ci: run the required dev checks on merge groups - #118

Open
Brad-Edwards wants to merge 1 commit into
devfrom
117-merge-group-checks
Open

Brad-Edwards wants to merge 1 commit into
devfrom
117-merge-group-checks

Conversation

@Brad-Edwards

Copy link
Copy Markdown
Collaborator

Summary

The dev merge queue merges a pull request only when each required check reports on the merge group commit. This change makes CodeQL, Lint PR title, and PR Gate run on the merge_group event and do their pull request validation there.

Changes

  • codeql-analysis.yml: runs on merge_group.
  • pr-title-lint.yml: runs on merge_group. It reads the queued pull request from the API and validates its current title with the base-ref checker. A missing checker fails on a merge group.
  • ci.yml: runs on merge_group. A new Queued pull request job reads the queued pull request number and head branch. Policy reads the requirement UID from that branch. SonarCloud runs a pull request analysis of the queued pull request against dev, with the quality gate. PR Gate runs on merge groups and requires SonarCloud success there.
  • tools/check_project_services.py: requires the merge_group trigger in the three workflows and the new PR Gate condition.
  • docs/maintainers/ci.md and project-services.md: describe the merge queue behavior.

Verification

  • actionlint on the three workflows: no findings.
  • zizmor --offline: no new findings compared to dev.
  • nox sessions hygiene, lint, tool-tests, policy -- --skip-requirement, and docs: pass.

Closes #117

The dev merge queue merges a pull request only when each required check
reports on the merge group commit. CodeQL, Lint PR title, and PR Gate now
run on the merge_group event and do their pull request validation there.

Closes #117
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant