Repository navigation
ci: run the required dev checks on merge groups - #118
Open
Brad-Edwards wants to merge 1 commit into
Open
Brad-Edwards wants to merge 1 commit into
Brad-Edwards wants to merge 1 commit into
Conversation
The dev merge queue merges a pull request only when each required check reports on the merge group commit. CodeQL, Lint PR title, and PR Gate now run on the merge_group event and do their pull request validation there. Closes #117
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The
devmerge queue merges a pull request only when each required check reports on the merge group commit. This change makesCodeQL,Lint PR title, andPR Gaterun on themerge_groupevent and do their pull request validation there.Changes
codeql-analysis.yml: runs onmerge_group.pr-title-lint.yml: runs onmerge_group. It reads the queued pull request from the API and validates its current title with the base-ref checker. A missing checker fails on a merge group.ci.yml: runs onmerge_group. A newQueued pull requestjob reads the queued pull request number and head branch.Policyreads the requirement UID from that branch.SonarCloudruns a pull request analysis of the queued pull request againstdev, with the quality gate.PR Gateruns on merge groups and requiresSonarCloudsuccess there.tools/check_project_services.py: requires themerge_grouptrigger in the three workflows and the newPR Gatecondition.docs/maintainers/ci.mdandproject-services.md: describe the merge queue behavior.Verification
actionlinton the three workflows: no findings.zizmor --offline: no new findings compared todev.noxsessionshygiene,lint,tool-tests,policy -- --skip-requirement, anddocs: pass.Closes #117