Duplicate manufacturer names (“Hewlett-Packard” + “HP”) appear in printer identifiers and DNS-SD; de-duplicate based on libcupsfilters logic.#117
Conversation
|
Hi! I'm not sure I want to go this way. There are so many manufacturers and each has its own ideas regarding naming things. And these ideas vary from model to model event on the same manufacturer... To simplify task of finding the right string for matching, the |
|
I think it makes sense to do the two exceptions CUPS does (and apparently is consistently done in all over linux code):
The rationale is that the main stream printing system does it. And it helps have uniform names. This also works the remove the duplicate prefix because vendors typical have the manufacturer as a prefix in the device name. Doing this helps to have consistent product name. CUPS has this logic in the two main backends (and few other places): |
Some HP printers have duplicated manufacturer names in multiple identifier fields, such as the full company name “Hewlett‑Packard” and its abbreviation “HP” appearing at the same time. This can cause recognition or matching issues.
Example:
Proposed Fix / Reference:
https://github.com/OpenPrinting/libcupsfilters/blob/5d1b247a73dcd68d7bf155436d2865ddaec7601b/cupsfilters/ieee1284.c#L327