-
Notifications
You must be signed in to change notification settings - Fork 1.6k
build: fix rule for building dynamic files #5565
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
Previously the architecture-specific dynamic files were relying on the built-in rules alone.
|
Sorry, I do not see what this would be fixing, when the built-in rule works fine (and has so for years) |
|
I appreciate the quick review, but please reopen this. This was accidentally relying on an old-fashioned technique (not my name for it, literally that is what this feature is called https://www.gnu.org/software/make/manual/html_node/Suffix-Rules.html) that does not work reliably for many uses. In particular, the rule is only implemented when $(SUFFIX) is defined to be |
|
Bump. Please reopen and merge this bugfix. |
|
Thanks for the explanation. Can you please let me know what environment/toolchain you are working with ? I assume it would have to be a Windows on Arm target environment (to require a specific dynamic_ARCH.c) and probably a cross-compiler that uses .obj extensions ? |
|
That is right. I'm using https://github.com/mstorsjo/llvm-mingw.git modified to add flang support (I have a PR there) to test various configurations of builds |
|
I see... I wasn't aware of that project, thanks for the pointer. (I guess you are aware that the native LLVM package for WoA does include flang already, unlike their Windows/x64 package ?) |
|
Yes, I'm working on integration with Julia, which is still mostly Makefile driven, and thus very annoying to deal with on Windows natively. That project lets me use mingw as the libraries to be able to use it from linux (WSL) |
|
Merge? |
Previously the architecture-specific dynamic files were relying on the built-in rules alone.