Update PR checker to check the project's artifact id#1096
Open
shin19991207 wants to merge 17 commits intostagingfrom
Open
Update PR checker to check the project's artifact id#1096shin19991207 wants to merge 17 commits intostagingfrom
shin19991207 wants to merge 17 commits intostagingfrom
Conversation
Merge staging to prod - add new microprofile-config-profile guide (#1069)
Merge staging to prod - Update docker-guides.json
Merge staging to prod - Update cloud-hosted-guides.json
Merge staging to prod - Update actions/upload-artifact to v4
Trigger gm container test (#1081)
Merge staging to prod - Update guide_categories.json
Merge staging to prod - Update guide_tags.json
Merge staging to prod - Update guide_prereqs.json
Merge staging to prod - Update guide_prereqs.json
Merge staging to prod - Update daily-build-java17.yml
Update guide_prereqs.json
Merge staging to prod - Update trigger-pre-daily-build.yml
Merge staging to prod - enable the jakarta-websocket guide to run java17 daily build (#1093)
gkwan-ibm
suggested changes
Jan 9, 2025
Contributor
gkwan-ibm
left a comment
gkwan-ibm
left a comment
There was a problem hiding this comment.
PR OpenLiberty/guide-maven-multimodules#189 should pass
- if server.xml does not have webApplication, it should not be an error
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Address #773