fix: enforce max 100 active tournament escrows per player - #927
Open
Davichi-1 wants to merge 1 commit into
Open
Conversation
Add a MAX_ACTIVE_ESCROWS cap (100) to prevent storage bloat attacks via create_tournament_escrow spam. Tracks per-player active escrow count in a separate Map<Address, u32>, incrementing on creation and decrementing on release. Adds the player Address field to the TournamentEscrow struct to facilitate count management on release. Closes OpenKnight-Foundation#864
|
@Davichi-1 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
Contributor
|
@Davichi-1 conflicts |
Contributor
|
@Davichi-1 please resolve conflicts |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
This PR adds a maximum cap on active tournament escrows per player to prevent storage bloat attacks. A malicious user could otherwise spam
create_tournament_escrowto bloat contract storage and increase fees for everyone.Related Issue
Closes #864
Changes
📈 Active Escrow Cap Enforcement
PLAYER_ACTIVE_ESCROWSstorage key – aMap<Address, u32>tracking per-player active escrow countMAX_ACTIVE_ESCROWS = 100constant – maximum allowed active escrows per unique user addressplayer: Addressfield toTournamentEscrowstruct to associate each escrow with its creatorMaxActiveEscrowsExceeded = 39error variantcreate_tournament_escrow– checks the per-player cap before creating, increments count on successrelease_tournament_escrow– decrements the player's count upon releaseVerification Results
Acceptance Criteria
MAX_ACTIVE_ESCROWS = 100create_tournament_escrowspamrelease_tournament_escrow