fix: add pagination metadata (BE-24) and structured JSON logging (BE-23) - #919
Open
mercy60 wants to merge 4 commits into
Open
fix: add pagination metadata (BE-24) and structured JSON logging (BE-23)#919mercy60 wants to merge 4 commits into
mercy60 wants to merge 4 commits into
Conversation
- BE-24 (OpenKnight-Foundation#872): Add total_count to list_games endpoint with offset pagination * Extracted shared filter condition builder to eliminate duplication * Added offset parameter for page-based navigation alongside cursor * Return total_count, next_cursor, and limit in response metadata - BE-23 (OpenKnight-Foundation#871): Replace env_logger with tracing for JSON structured logging * Configure tracing_subscriber with pretty output (debug) and JSON (release) * Add TracingLogger middleware for automatic HTTP request/response logging * Replace all eprintln!/println! calls with tracing info!/warn!/error! macros Closes OpenKnight-Foundation#871 Closes OpenKnight-Foundation#872
|
@mercy60 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
…ng (BE-23) - Replace log/env_logger with tracing/tracing-subscriber across all crates - Socket server: env_logger → tracing_subscriber with pretty/json mode per build profile - Service, matchmaking, API modules: all log:: macros → tracing:: macros - Remove log dep from service and matchmaking Cargo.toml; add tracing - Socket Cargo.toml: remove log+env_logger, add tracing+tracing-subscriber - BE-24: pagination metadata (total_count, next_cursor) already wired in list_games - Zero remaining log:: references in any Rust source file
- Add missing imports: JwtService, JwtAuthMiddleware, Migrator, MigratorTrait, MatchmakingService, create_redis_pool, test_redis_connection - Fix variable shadowing: server → http_server in workers() call - Comment out dead configure_nft_routes reference (not yet implemented) - Remove unused DatabaseConnection import - cargo check -p api and cargo build --workspace now pass
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BE-24 (BE-24: Add pagination to game history and tournament list endpoints #872): Add total_count to list_games endpoint with offset pagination
BE-23 (BE-23: Setup centralized structured logging (JSON) for production observability #871): Replace env_logger with tracing for JSON structured logging
Closes #871
Closes #872