Skip to content

ci, docs: build and smoke-test the Novatek SPI NAND images - #102

Merged
dimerr merged 1 commit into
openipcfrom
ci/novatek-spi-nand
Nov 4, 2026
Merged

dimerr merged 1 commit into
openipcfrom
ci/novatek-spi-nand

Conversation

@dimerr

@dimerr dimerr commented Nov 4, 2026

Copy link
Copy Markdown
Collaborator

CI and README for the SPI NAND images in #101:

  • Build: four legs, nt98560-nand, nt98562-nand, nt98566-nand and nt98525-nand, each uploaded as artifact u-boot-<soc>-nand. A new target matrix field names what build.sh builds when it differs from the SoC. The size limit is the 2816 KiB boot area.
  • Smoke test: four legs boot each image from 128 MiB of SPI NAND on its SoC's machine.
  • README: the four SoCs get "NOR, SPI NAND" in the table, plus a note on the NAND layout.

Merge after #101: these legs build targets that PR adds.

nt98560-nand, nt98562-nand, nt98566-nand, nt98525-nand: a build leg
each (artifact u-boot-<soc>-nand, the 2816 KiB boot area as its limit)
and a smoke leg booting it from 128 MiB of SPI NAND.
@qodo-free-for-open-source-projects

Copy link
Copy Markdown

PR Summary by Qodo

Build and smoke-test four Novatek SPI NAND images

⚙️ Configuration changes 🧪 Tests 📝 Documentation 🕐 10-20 Minutes

Grey Divider

AI Description

• Add four SPI NAND build legs with distinct artifacts and 2816 KiB size limits.
• Smoke-test each image from 128 MiB of emulated NAND across two boots.
• Document supported SoCs and NAND layout; the new build targets require #101.
Diagram

graph TD
  M["Build matrix"] --> B["NAND targets"] --> F{"2816 KiB fit?"} --> A["Named artifacts"] --> S["QEMU smoke"] --> P["Optional publish"]
  Q["QEMU binary"] --> S
Loading
High-Level Assessment

Extending the existing build and smoke-test matrices reuses their size, boot, and publication gates without introducing a separate NAND pipeline. Keep the dependency on #101 explicit: these legs need its build targets.

Files changed (2) +29 / -10

Documentation (1) +11 / -4
README.mdDocument Novatek SPI NAND support and flash layout +11/-4

Document Novatek SPI NAND support and flash layout

• Marks the four SoCs as supporting SPI NAND alongside NOR. Documents loader, device-tree, U-Boot, environment, and UBI locations, plus the NT98525 loader's SD-update limitation.

README.md

Other (1) +18 / -6
build-novatek.ymlAdd four NAND build and QEMU smoke-test legs +18/-6

Add four NAND build and QEMU smoke-test legs

• Adds explicit NAND targets for NT98560, NT98562, NT98566, and NT98525, with distinct artifact names and 2816 KiB boot-area limits. Adds smoke-test legs that boot each artifact from 128 MiB of emulated SPI NAND, while preserving the existing two-boot environment check.

.github/workflows/build-novatek.yml

@qodo-free-for-open-source-projects

Copy link
Copy Markdown

Code Review by Qodo

🐞 Bugs (0) 📘 Rule violations (0) 📎 Requirement gaps (0)

Grey Divider

Great, no issues found!

Qodo reviewed your code and found no material issues that require review

Grey Divider

Tip of the day
💡 Did you know, you can commit Qodo's fix in one click with committable suggestions (GitHub & GitLab)

More tips ↗ | Customize Qodo ↗ | Qodo docs ↗

Grey Divider

Qodo Logo

@dimerr
dimerr merged commit 591119c into openipc Nov 4, 2026
95 of 99 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant