[compot-dev]

Fixes #29, fixes #26, fixes #24, fixes #25. One commit per issue.

Issue	Problem	Fix
#29	Google Play hides the app on devices without a touchscreen (TV)	<uses-feature android:name="android.hardware.touchscreen" android:required="false"/>
#26	A stale 1 s / 5 s timer from "connected" overwrites or hides "Disconnected"	The timers are fields; every updateStatus() cancels them with removeCallbacks()
#24	After an uncaught exception the process keeps running in a broken state	The process is ended after Crash is started; Crash runs in its own :crash process
#25	WebUI sends the camera credentials to any host that asks for HTTP auth	handler.proceed() only when the requesting host equals the camera host; otherwise cancel()

About #24

Lint still warns about DefaultUncaughtExceptionDelegation, and this is deliberate. Handing the exception to the system handler would show the system "app keeps stopping" dialog on top of our own crash screen. Instead the process is ended explicitly with killProcess + exit. The Crash activity lives in a separate process, so it survives this and shows the stack trace.

Verification

• assembleDebug: OK. lintDebug: errors go from 3 to 2. ImpliedTouchscreenHardware is gone; the remaining two are Android 16 (targetSdk 36): migrate Back handling to OnBackInvokedCallback #30 and Cleanup: small code issues #35.
• Not tested on a device. Worth checking there:
  • the crash screen appears after a crash, and the app restarts cleanly afterwards;
  • in WebUI, the camera login still works.

[qodo-free-for-open-source-projects]

PR Summary by Qodo

Fix TV availability, status timers, crash recovery, and WebUI auth

🐞 Bug fix ⚙️ Configuration changes 🕐 20-40 Minutes

AI Description

• Make touchscreen optional for TV availability and isolate crash reporting from the terminated app
 process.
• Cancel stale connection-overlay timers so later status messages remain visible.
• Send WebUI HTTP-auth credentials only to the configured camera host.

Diagram

graph TD
  Manifest["Android manifest"] --> Play["Google Play"]
  App["Crash handler"] --> Crash["Crash screen"]
  Decoder["Stream status"] --> Overlay["Status overlay"]
  WebUI["WebUI auth"] --> Camera["Camera host"]
  Manifest --> Crash

Loading

High-Level Assessment

The localized fixes fit four independent issues. Explicit callback cancellation preserves the existing overlay behavior, and a separate crash process lets the report remain visible after the failed process ends. Broader status-state or authentication redesigns would add scope without a clear benefit here; device testing should confirm crash display and camera login.

Files changed (4) +52 / -35

Bug fix (3) +48 / -34

App.javaEnd the failed process after launching crash reporting +12/-5

End the failed process after launching crash reporting

• Starts the Crash activity with the exception stack trace, then kills and exits the failed process in a finally block, including if activity launch fails.

android/app/src/main/java/com/openipc/decoder/App.java

Decoder.javaCancel stale connected-status overlay callbacks +34/-28

Cancel stale connected-status overlay callbacks

• Moves the delayed details and hide callbacks into reusable fields and cancels both before each status change. This prevents earlier connected-state timers from overwriting or hiding a later status.

android/app/src/main/java/com/openipc/decoder/Decoder.java

MenuManager.javaRestrict WebUI credentials to the camera host +2/-1

Restrict WebUI credentials to the camera host

• Compares the HTTP-auth requesting host with the configured camera host before supplying credentials. Requests from other hosts are cancelled, including those reached through redirects or links.

android/app/src/main/java/com/openipc/decoder/MenuManager.java

Other (1) +4 / -1

AndroidManifest.xmlAllow non-touchscreen devices and isolate the crash activity +4/-1

Allow non-touchscreen devices and isolate the crash activity

• Marks touchscreen hardware as optional so Google Play does not exclude TVs and set-top boxes. Assigns the Crash activity to a separate process so it can remain visible when the main process is killed.

android/app/src/main/AndroidManifest.xml

[qodo-free-for-open-source-projects]

Code Review by Qodo

🐞 Bugs (0) 📘 Rule violations (0) 📎 Requirement gaps (0)

Great, no issues found!

Qodo reviewed your code and found no material issues that require review

Tip of the day

💡 Did you know, you can commit Qodo's fix in one click with committable suggestions (GitHub & GitLab)

More tips ↗ | Customize Qodo ↗ | Qodo docs ↗