fix(security-scan): improve release security scan comment - #4397
Open
all-hands-bot wants to merge 1 commit into
Open
fix(security-scan): improve release security scan comment#4397all-hands-bot wants to merge 1 commit into
all-hands-bot wants to merge 1 commit into
Conversation
Three adjustments to the release security-scan workflow comment: 1. Status line says "finding(s)" instead of "blocking finding(s)" — the findings are already marked as blocking by the emoji/verdict; the extra word is redundant. 2. The merged-head SHA in approval-drift rows is now a markdown link to the GitHub compare page between the last reviewed commit and the merged head, so reviewers can jump straight to what landed after approval. 3. Internal openhands-* package bumps are excluded from the external-dep count (they bump on every release) but still displayed in a separate collapsible section at the bottom of the dependency-diff report. Co-authored-by: openhands <openhands@all-hands.dev>
Contributor
Python API breakage checks — ✅ PASSEDResult: ✅ PASSED |
Contributor
REST API breakage checks (OpenAPI) — ✅ PASSEDResult: ✅ PASSED |
Collaborator
Author
|
👋 This PR needs a couple of things fixed before OpenHands can review it:
Push an update once this is addressed and this check re-runs automatically. This is an automated check - no AI was used to generate this comment. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Three adjustments to the release security-scan workflow comment, based on feedback on the comment posted by the bot on #4393.
Changes
"blocking findings" → "findings" — the status line in
Report.render()now says❌ N finding(s)instead of❌ N blocking finding(s). The findings are already flagged as blocking by the verdict/emoji; the extra word is redundant.Link the diff between reviewed commit and merged head — in the approval-drift table, the merged-head SHA is now a markdown link to the GitHub compare page between the last reviewed commit and the merged head, e.g.:
This lets reviewers jump straight to what landed after approval.
Exclude
openhands-*from the dep count, still display them — internalopenhands-*packages bump on every release and inflate the external-dep count. They are now:bumped: Ncount (only external deps counted)_(plus N internal openhands-* bump(s))_Internal openhands-* bumpsat the bottomFiles changed
.github/scripts/security_scan_common.py—Report.render()status line.github/scripts/check_approval_drift.py—_compare_link()helper + usage inaudit_pr().github/scripts/check_dependency_diff.py— splitbumpedinto external/openhands, update count + inventoryThis PR was created by an AI agent (OpenHands) on behalf of Vasco.