-
Notifications
You must be signed in to change notification settings - Fork 268
Add LLM subscription auth endpoints #3367
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
neubig
wants to merge
9
commits into
main
Choose a base branch
from
add-llm-subscription-endpoints
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
c47c755
Add LLM subscription auth endpoints
openhands-agent a97e864
Address subscription auth lifecycle review
openhands-agent bb71494
Harden subscription credential refresh lifecycle
openhands-agent eb74e09
Avoid persisting subscription runtime tokens
openhands-agent 935bd65
Fix subscription router test typing
openhands-agent 1605170
Bind subscription runtime auth without serializing tokens
openhands-agent 92dff09
Bind OpenAI subscription LLM to credential store
openhands-agent 0acf5e3
Refresh CI after review rerun
openhands-agent 9fd55ba
Merge branch 'main' into add-llm-subscription-endpoints
neubig File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🟠 Important:
refresh_if_needed()can write refreshed credentials, but this endpoint does it outside the device-login/logout lock. If a status request starts refreshing an expired old token while a device poll saves a newly completed login, the later refresh write can overwrite the new credentials. Please serialize all credential writes (refresh,save,logout) or add a compare-and-swap check in the credential store.