Skip to content

fix(skills): prefer frontmatter description over body content in slash command menu#673

Merged
VascoSch92 merged 3 commits into
mainfrom
vasco/command-fix-description
May 27, 2026
Merged

fix(skills): prefer frontmatter description over body content in slash command menu#673
VascoSch92 merged 3 commits into
mainfrom
vasco/command-fix-description

Conversation

@VascoSch92
Copy link
Copy Markdown
Member

@VascoSch92 VascoSch92 commented May 20, 2026

  • A human has tested these changes.

Summary

Swap the two branches in SlashCommandMenuItem so a skill's description field is used before falling back to parsing its content. Previously content took priority, so SKILL.md skills showed a truncated first body line instead of their curated frontmatter description. Items without a description still fall back to content parsing.

Snapshots

Before

Screenshot 2026-05-20 at 18 24 45

After

Screenshot 2026-05-20 at 18 24 04

Type

  • Bug fix
  • Feature
  • Refactor
  • Breaking change
  • Docs / chore

🐳 Docker images for this PR

GHCR package: https://github.com/OpenHands/agent-canvas/pkgs/container/agent-canvas

Component Value
Image ghcr.io/openhands/agent-canvas
Architectures amd64, arm64
Agent Server ghcr.io/openhands/agent-server:1.23.1-python
Automation openhands-automation==1.0.0a5
Commit fc3769f5c563e2f5e02f643f2c06073769fad845

Pull (multi-arch manifest)

# Multi-arch manifest — Docker automatically pulls the correct architecture
docker pull ghcr.io/openhands/agent-canvas:sha-fc3769f

Run

docker run -it --rm \
  -p 8000:8000 \
  ghcr.io/openhands/agent-canvas:sha-fc3769f

All tags pushed for this build

ghcr.io/openhands/agent-canvas:sha-fc3769f-amd64
ghcr.io/openhands/agent-canvas:vasco-command-fix-description-amd64
ghcr.io/openhands/agent-canvas:pr-673-amd64
ghcr.io/openhands/agent-canvas:sha-fc3769f-arm64
ghcr.io/openhands/agent-canvas:vasco-command-fix-description-arm64
ghcr.io/openhands/agent-canvas:pr-673-arm64
ghcr.io/openhands/agent-canvas:sha-fc3769f
ghcr.io/openhands/agent-canvas:vasco-command-fix-description
ghcr.io/openhands/agent-canvas:pr-673

About Multi-Architecture Support

  • Each tag (e.g., sha-fc3769f) is a multi-arch manifest supporting both amd64 and arm64
  • Docker automatically pulls the correct architecture for your platform
  • Individual architecture tags (e.g., sha-fc3769f-amd64) are also available if needed

@VascoSch92 VascoSch92 requested a review from all-hands-bot May 20, 2026 16:27
@vercel
Copy link
Copy Markdown

vercel Bot commented May 20, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
agent-canvas Ready Ready Preview, Comment May 27, 2026 9:29am

Request Review

Copy link
Copy Markdown
Contributor

@all-hands-bot all-hands-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Good taste — Clean fix that correctly prioritizes explicit metadata over derived content.

Key insight: Swapping the priority order so description (curated frontmatter) takes precedence over content (parsed body) aligns with semantic correctness. Skills with explicit descriptions now display properly instead of showing truncated first-line content.

Risk Assessment: 🟢 LOW

  • Single file, 3-line logic swap
  • Correct semantic priority (metadata before parsing)
  • Visual proof in screenshots
  • No breaking changes, security concerns, or eval risk

Was this automated review useful? React with 👍 or 👎 to this review to help us measure review quality.
Workflow run: https://github.com/OpenHands/agent-canvas/actions/runs/26175810678

@VascoSch92 VascoSch92 requested a review from hieptl May 20, 2026 16:31
@VascoSch92 VascoSch92 merged commit a3c96bf into main May 27, 2026
14 checks passed
@VascoSch92 VascoSch92 deleted the vasco/command-fix-description branch May 27, 2026 09:35
@github-actions
Copy link
Copy Markdown
Contributor

📸 Snapshot Test Report

Warning

Snapshot comparison step crashed (timeout, OOM, or runner error) — diff results below may be incomplete or absent.
Check the CI logs for the full error output (look for the "Run snapshot comparison" step).

✅ All snapshots match the main branch baselines.

Category Count
🔴 Changed 0
🆕 New 0
✅ Unchanged 73
Total 73
✅ Unchanged snapshots (73)

archived-conversation

  • conversation-panel-with-archived-badges
  • conversation-view-archived
  • conversation-view-sandbox-error

automations

  • automations-delete-modal
  • automations-list-active-inactive
  • automations-no-automations
  • automations-search-no-results

backends-extended

  • backend-add-blank-disabled
  • backend-add-cloud-advanced-open
  • backend-add-cloud-no-key-disabled
  • backend-add-cloud-with-key-enabled
  • backend-add-form-partially-filled
  • backend-add-invalid-url-disabled
  • backend-add-local-ready
  • backend-add-name-only-disabled
  • backend-add-two-column-layout
  • backend-add-whitespace-host-disabled
  • backend-after-switch
  • backend-cancel-nothing-saved
  • backend-dropdown-two-backends
  • backend-edit-prefilled
  • backend-manage-after-removal
  • backend-manage-two-listed
  • backend-remove-cancelled
  • backend-remove-confirmation
  • backend-switch-overlay

backends

  • backend-add-modal
  • backend-manage-modal
  • backend-selector-open

changes-tab

  • changes-deleted-file
  • changes-diff-viewer
  • changes-empty

collapsible-thinking

  • reasoning-content-collapsed
  • reasoning-content-expanded
  • think-action-collapsed
  • think-action-expanded

mcp-page

  • mcp-custom-server-1-editor-open
  • mcp-custom-server-2-url-filled
  • mcp-custom-server-3-all-filled
  • mcp-custom-server-4-installed
  • mcp-custom-server-editor
  • mcp-empty-installed
  • mcp-search-filtered
  • mcp-slack-install-1-marketplace
  • mcp-slack-install-2-modal
  • mcp-slack-install-3-filled
  • mcp-slack-install-4-installed

onboarding

  • onboarding-step-0-choose-agent
  • onboarding-step-1-check-backend
  • onboarding-step-2-setup-llm
  • onboarding-step-3-say-hello

projects-workspace-browser

  • projects-workspace-browser

settings-page

  • add-backend-modal
  • analytics-consent-modal
  • home-screen
  • settings-app-page
  • settings-page

settings-secrets

  • secrets-add-form-filled
  • secrets-add-form
  • secrets-after-save
  • secrets-delete-confirm
  • secrets-list

settings-verification

  • condenser-settings
  • verification-settings-off
  • verification-settings-on

sidebar

  • sidebar-collapsed
  • sidebar-conversation-panel
  • sidebar-filter-menu

skills-page

  • skills-empty
  • skills-loaded
  • skills-no-match
  • skills-search-filtered
  • skills-type-filter

Generated by the Snapshot Tests workflow. This comment was created by an AI agent (OpenHands) on behalf of the repo maintainers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants