docs(acp): document **_kwargs pattern for protocol compatibility#683
Open
github-actions[bot] wants to merge 1 commit into
Open
docs(acp): document **_kwargs pattern for protocol compatibility#683github-actions[bot] wants to merge 1 commit into
github-actions[bot] wants to merge 1 commit into
Conversation
Add module-level documentation explaining why methods in base_agent.py use **_kwargs: Any parameters. This pattern enables: - Forward compatibility with future ACP protocol versions - Graceful handling of parameters from different ACP clients - Flexibility for subclass implementations Addresses item from code quality report. Closes #681 Co-authored-by: openhands <openhands@all-hands.dev>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds module-level documentation to
base_agent.pyexplaining why ACP agent methods use**_kwargs: Anyparameters.This documentation clarifies that the pattern is intentional for ACP protocol forward compatibility, rather than being a code smell or oversight.
Changes
**_kwargspatternRelated Issue
Addresses findings from #681
Testing
make lint)make test)This PR was automatically generated by the Code Quality Report workflow.