fix(utils): extract format_metrics_status_line to shared utilities#682
Open
github-actions[bot] wants to merge 1 commit into
Open
fix(utils): extract format_metrics_status_line to shared utilities#682github-actions[bot] wants to merge 1 commit into
github-actions[bot] wants to merge 1 commit into
Conversation
Move the _format_status_line function from acp_impl/events/utils.py to openhands_cli/utils.py as format_metrics_status_line, making it available for reuse across both ACP and TUI contexts. Addresses item from code quality report. Closes #681 Co-authored-by: openhands <openhands@all-hands.dev>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Extracts the
_format_status_linefunction fromacp_impl/events/utils.pyto a shared location inopenhands_cli/utils.pyasformat_metrics_status_line.This makes the metrics formatting logic reusable across both ACP and TUI contexts, reducing code duplication and improving maintainability.
Changes
format_metrics_status_linefunction toopenhands_cli/utils.pyacp_impl/events/utils.pyto import and use the shared functionabbreviate_number,format_cost,TokenUsage)Related Issue
Addresses findings from #681
Testing
make lint)make test)This PR was automatically generated by the Code Quality Report workflow.