Count low-disk warnings separately from probe diagnostics - #358
Open
peter-lawrey wants to merge 2 commits into
Open
peter-lawrey wants to merge 2 commits into
peter-lawrey wants to merge 2 commits into
Conversation
…-monitor-warning-count
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DiskSpaceMonitorTest.pollDiskSpacecounted PERF messages from slow file-store probes as low-disk warnings, so a busy host could fail despite the expected warning frequency. Count only the scheduled low-space WARN messages and inject additional PERF messages in the fixture to cover this distinction. The threshold, observation period, warning-count range and production monitor remain unchanged.Stacked on #357 to keep this fixture correction separate. The behaviour and regression mapping are documented in
src/main/docs/disk-monitor-test-warnings.adoc.