Conversation
scardracs
force-pushed
the
leds/dynamic-lighting
branch
4 times, most recently
from
September 5, 2026 12:09
005fb1f to
c6ee973
Compare
NeroReflex
reviewed
Sep 5, 2026
scardracs
force-pushed
the
leds/dynamic-lighting
branch
from
September 5, 2026 14:23
c6ee973 to
2ce82cc
Compare
Author
|
I've moved the patch to 7.2 in order to have some stability (7.3 is way too bugged as for now). When the situation will be better I'll move it back to 7.3. I leave that draft open for now |
pastaq
reviewed
Sep 7, 2026
scardracs
force-pushed
the
leds/dynamic-lighting
branch
2 times, most recently
from
September 8, 2026 14:19
45f6a76 to
1a38a2e
Compare
scardracs
changed the title
scardracs
force-pushed
the
leds/dynamic-lighting
branch
from
September 8, 2026 18:30
1a38a2e to
4e550e9
Compare
Author
|
Added an aura:global that controls both keyboard and lightbar for those devices that don't have the ability to control them separately |
7 tasks
scardracs
force-pushed
the
leds/dynamic-lighting
branch
4 times, most recently
from
September 9, 2026 07:42
3a706b9 to
a4d18f6
Compare
Grippy98
pushed a commit
to Grippy98/linux-unstable
that referenced
this pull request
Sep 10, 2026
cifs.idmap key descriptions carry authority-bearing fields (owner and group SIDs and uid/gid values in "os:"/"gs:"/"oi:"/"gi:" form) that the cifs.idmap upcall helper treats as kernel-originating inputs. Unlike its sibling cifs.spnego, the cifs.idmap key type has no vet_description hook, so userspace can create keys of this type through request_key(2)/add_key(2) and supply those fields without CIFS origin. A request_key(2) call with a non-NULL callout then drives a root usermodehelper upcall (/sbin/request-key -> cifs.idmap) that consumes the unvetted description in root context. Only accept cifs.idmap descriptions while CIFS is using its private root_cred to request the key. id_to_sid()/sid_to_id() already run under override_creds(root_cred), so the kernel-originated path is unaffected. This mirrors commit 3da1fdf ("smb: client: reject userspace cifs.spnego descriptions"), which applied the same restriction to cifs.spnego. Fixes: 4d79dba ("cifs: Add idmap key and related data structures and functions (try OpenGamingCollective#17 repost)") Reported-by: TencentOS Corvus AI <corvus@tencent.com> Cc: stable@vger.kernel.org Assisted-by: CodeBuddy:Kimi-K3 Signed-off-by: Aohan Mei <henrymei@tencent.com> Acked-by: David Howells <dhowells@redhat.com> Signed-off-by: Paulo Alcantara <pc@manguebit.org>
scardracs
force-pushed
the
leds/dynamic-lighting
branch
3 times, most recently
from
September 12, 2026 17:02
8ef5708 to
87dbb4b
Compare
Define LED_DYNAMIC_LIGHTING flag in struct led_classdev to enable runtime type identification for Dynamic Lighting class devices, matching the established pattern used by LED_MULTI_COLOR. Signed-off-by: Marco Scardovi <scardracs@disroot.org>
Add a dedicated Dynamic Lighting LED class for devices that expose multi-LED effects, palette programming, direct frame streaming or lighting state persistence through sysfs. The new class extends struct led_classdev with common effect, speed, direction and power-state controls, plus binary write interfaces for packed RGB frames and device-specific frame payloads. Registration validates the exported capabilities, exposes only the attributes implemented by the driver, and serializes writes under led_access and the class-private lock so drivers can coexist safely with LED triggers. After a successful direct_write the class sets current_effect to DIRECT when that effect is advertised, so drivers must not mutate it before the HID/USB write succeeds. This provides a common kernel ABI for complex lighting devices without requiring each driver to invent its own sysfs layout. Signed-off-by: Marco Scardovi <scardracs@disroot.org>
Document the Dynamic Lighting LED class ABI and user-facing sysfs interface. Describe the common attributes, the visibility rules for optional controls, the discoverability attributes used by programmable devices, and the write semantics for the direct and frame binary interfaces. Writing power_states replaces the active bitmask (an empty list clears all enabled states). Also add the new document to the LED documentation index and register it in MAINTAINERS. Signed-off-by: Marco Scardovi <scardracs@disroot.org>
Add Dynamic Lighting class support to hid-asus for Aura-capable ROG keyboards, chassis lightbars, and Slash LED bars. Discover Aura layout, lightbar, and per-key/direct RGB from HID feature reports rather than DMI board lists. Register Slash when feature report 0x5e is present, or on USB 0x193b when Aura LED reports exist; skip AniMe Matrix interfaces that reuse 0x193b without those reports. Register aura:global / aura:keyboard / aura:lightbar with aura_mode (auto/unified/split). auto resolves to split so keyboard and lightbar stay independently writable. Advertise DIRECT on global when the keyboard path supports direct RGB. On N-KEY devices where Aura 0xBC cannot drive the chassis lightbar independently, use the sibling HID LampArray interface as the in-kernel direct-RGB backend (no hidraw) and drop the owner reference on unbind. Fall back to Aura 0xBC when LampArray is absent. Map boot/awake/sleep/shutdown via power_states to AURA_CMD_POWER (0xbd) without rewriting zone power from brightness or resume. Keep asus::kbd_backlight brightness behaviour unchanged. Signed-off-by: Marco Scardovi <scardracs@disroot.org>
Expose Dynamic Lighting class attributes on asus::kbd_backlight when TUF RGB control is supported (kbd_rgb_dev). Register via devm_led_classdev_dynamic_register with effects, speed, palette, and power-state persistence through ACPI WMI methods. Map DL_POWER_STATE_* bits directly; they are already BIT(n) values. Always initialize the keyboard LED cdev name before queuing registration work so HID listener registration cannot oops on a NULL name when WMI kbd backlight setup was skipped. Preserve legacy kbd_rgb_mode and kbd_rgb_state sysfs attributes for backward compatibility. Signed-off-by: Marco Scardovi <scardracs@disroot.org>
…osures ASUS ROG external NVMe enclosures (such as the ROG STRIX Arion, USB ID 0b05:1932) are USB mass-storage devices with no HID interface. Their addressable Aura RGB LEDs hang off an onboard ENE microcontroller driven via 16-byte vendor SCSI commands on the same LUN as the storage. Add the leds-asus-aura-scsi driver using a class_interface registered with the SCSI class. Its add callback matches INQUIRY vendor "ROG" and model "ESD-S1C", retains the SCSI device while the LED is registered, and leaves disk ownership and access untouched for the sd driver. Each matching enclosure exposes a uniquely named Dynamic Lighting device: asus-aura-scsi-<H_C_T_L>:rgb:indicator. Hardware animation offloads (Off, Static, Breathing, Strobe, Spectrum Cycle, Rainbow, Direct streaming), speed (0..4), direction (right/left), palette, and direct RGB frame streaming via direct_buffer are fully integrated. direct_write updates current_mode after a successful apply. Signed-off-by: Marco Scardovi <scardracs@disroot.org>
scardracs
force-pushed
the
leds/dynamic-lighting
branch
from
September 13, 2026 10:23
fb74985 to
907aeed
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This pull request introduces the Dynamic Lighting LED class to the kernel and adds driver support in
hid-asusfor ASUS ROG Aura keyboards and chassis lightbars.It provides a standard sysfs ABI for devices that expose multi-zone effects, palette programming, direct RGB frame streaming, and lighting power-state persistence, without requiring individual drivers to invent ad-hoc sysfs layouts.
NOTE: due to heavy work on both here and linux the text on that OP can or cannot be accurate
Commits Overview
leds: Add LED_DYNAMIC_LIGHTING flag to LED coreLED_DYNAMIC_LIGHTINGinstruct led_classdevto enable runtime identification of Dynamic Lighting class devices, following the pattern ofLED_MULTI_COLOR.leds: dynamic: Add Dynamic Lighting core class interfacedrivers/leds/led-class-dynamic.c,include/linux/led-dynamic-lighting.h) extendingled_classdev.led_accessand the class mutex to ensure thread safety alongside LED triggers.docs: leds: Document the Dynamic Lighting class ABIDocumentation/ABI/testing/sysfs-class-leds-dynamicandDocumentation/leds/leds-class-dynamic.rst.Documentation/leds/index.rstand registers the subsystem files inMAINTAINERS.HID: asus: Add Dynamic Lighting support for Aura deviceshid-asus.0xbd), zone activation (0xc0), and hardware effect engine programming (0xb3) with the firmware latch commit sequence (0xb5 SET->0xb4 COMMIT->0xb5 SET).asus::kbd_backlightbrightness control.