Skip to content

feat(rog-aura): add aura support for ROG Strix G16 G614FP - #376

Merged
Ghoul4500 merged 1 commit into
OpenGamingCollective:mainfrom
MsN-12:g614fp-aura-support
Sep 12, 2026
Merged

Ghoul4500 merged 1 commit into
OpenGamingCollective:mainfrom
MsN-12:g614fp-aura-support

Conversation

@MsN-12

@MsN-12 MsN-12 commented Sep 12, 2026

Copy link
Copy Markdown
Contributor

Description

Adds Aura support for the ASUS ROG Strix G16 G614FP.

Without an entry in rog-aura/data/aura_support.ron, asusd falls back to the
generic default for board G614FP (only the Keyboard power zone, no per-key
support). As a result the front bottom Lightbar is never initialised and
stays dark, and asusctl aura power lightbar has no effect.

This adds a G614FP entry (Aura device 19b6) modelled on the already-tested
G614PP entry: per-key keyboard plus the Lightbar power zone. It was
validated on the machine by loading the identical entry through the supported
user override /etc/asusd/asusd_user_ledmodes.ron before submitting.

Fixes: N/A (no existing issue)

Tested Hardware & Environment

  • ASUS Laptop Model: ROG Strix G16 G614FP (AMD Ryzen 9 9955HX)
  • Linux Distribution: Omarchy 4.0.3 (Arch-based)
  • Kernel Version: 7.2.3-arch1-3

Verification performed:

  • With the entry loaded, asusd logs Matched to G614FP -> Matched to 19b6
    and regenerates /etc/asusd/aura_19b6.ron with both Keyboard and Lightbar
    power states.
  • The front bottom light bar powers on and responds to
    asusctl aura power lightbar --boot --awake --sleep --shutdown and
    asusctl aura effect static -c <colour>.

Notes:

  • The lid Logo zone is intentionally omitted (same as G614PP) because it was
    not tested on this unit.
  • Only the data file changed; no Rust code was touched. cargo was not
    available on my machine, so I could not run the local test suite; the
    rog-aura data-file tests (sorting / layout links) should run in CI.
  • AI assistance was used to diagnose the missing model entry and draft this
    description. The hardware testing and the final review of the change were
    done by me.

Verification and testing:

  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My code follows the style guidelines of this project (cargo fmt --all -- --check)
  • My changes generate no new warnings (cargo clippy --all -- -D warnings/cargo check --all-targets)
  • New and existing unit tests pass locally with my changes (cargo test --all)
  • Cranky with 0 warning (cargo cranky)

The G614FP (AMD Ryzen 9 9955HX, Aura device 19b6) is missing from the aura support database, so asusd falls back to the generic Keyboard-only default. As a result the front bottom Lightbar zone is never initialised and stays dark.

Add a G614FP entry matching the tested G614PP configuration (per-key keyboard + Lightbar). Verified on hardware that the bottom light bar powers on and responds to asusctl aura power/effect commands.
@coderabbitai

coderabbitai Bot commented Sep 12, 2026

Copy link
Copy Markdown

Review Change StackReview Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: ASSERTIVE

Plan: Advanced

Run ID: 5c9d299b-161a-4f81-a47e-7359e2870b26

📥 Commits

Reviewing files that changed from the base of the PR and between d51d149 and 2f9693a.

📒 Files selected for processing (1)
  • rog-aura/data/aura_support.ron

Included review availability: Your plan provides up to 4 included reviews per hour; 3 remain after this review.

📜 Recent review details
🔇 Additional comments (1)
rog-aura/data/aura_support.ron (1)

371-379: LGTM!


📝 Summary

Summary by CodeRabbit

  • New Features
    • Added Aura support for the G614FP laptop, including per-key lighting and lightbar controls.
    • Added support for Static, Breathe, Rainbow Cycle, Rainbow Wave, and Pulse lighting modes.

Walkthrough

The Aura support configuration adds the G614FP laptop with its product ID, per-key layout, supported lighting modes, advanced type, and power zones.

Changes

G614FP Aura Support

Layer / File(s) Summary
Register G614FP support
rog-aura/data/aura_support.ron
Adds product ID 19b6, the g634j-per-key layout, five basic modes, PerKey support, and Keyboard and Lightbar power zones.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~3 minutes

Change: Feature

Suggested labels: rog-aura, enhancement

Suggested reviewers: scardracs

Merge Risk: ⚪ Minimal · up to 2f969

The G614FP Aura metadata is narrowly scoped and hardware-validated, with no merge-blocking risk remaining.

🚥 Pre-merge checks | ✅ 4
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and concisely identifies the main change: adding Aura support for the ASUS ROG Strix G16 G614FP.
Description check ✅ Passed The description follows the repository template, explains the problem and solution, identifies tested hardware and environment, documents validation results, and records unrun checks with reasons. The…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@coderabbitai coderabbitai Bot added enhancement New feature or request rog-aura Keyboard / Aura RGB labels Sep 12, 2026

@Ghoul4500 Ghoul4500 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution

@Ghoul4500
Ghoul4500 merged commit 3a59b81 into OpenGamingCollective:main Sep 12, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request rog-aura Keyboard / Aura RGB

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants