feat(rog-aura): add aura support for ROG Strix G16 G614FP - #376
Conversation
The G614FP (AMD Ryzen 9 9955HX, Aura device 19b6) is missing from the aura support database, so asusd falls back to the generic Keyboard-only default. As a result the front bottom Lightbar zone is never initialised and stays dark. Add a G614FP entry matching the tested G614PP configuration (per-key keyboard + Lightbar). Verified on hardware that the bottom light bar powers on and responds to asusctl aura power/effect commands.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository UI Review profile: ASSERTIVE Plan: Advanced Run ID: 📒 Files selected for processing (1)
Included review availability: Your plan provides up to 4 included reviews per hour; 3 remain after this review. 📜 Recent review details🔇 Additional comments (1)
📝 SummarySummary by CodeRabbit
WalkthroughThe Aura support configuration adds the G614FP laptop with its product ID, per-key layout, supported lighting modes, advanced type, and power zones. ChangesG614FP Aura Support
Priority: ⬇️ Low Estimated code review effort: 1 (Trivial) | ~3 minutes Change: Feature Suggested labels: Suggested reviewers: Merge Risk: ⚪ Minimal · up to The G614FP Aura metadata is narrowly scoped and hardware-validated, with no merge-blocking risk remaining. 🚥 Pre-merge checks | ✅ 4✅ Passed checks (4 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Ghoul4500
left a comment
There was a problem hiding this comment.
Thank you for your contribution
Description
Adds Aura support for the ASUS ROG Strix G16 G614FP.
Without an entry in
rog-aura/data/aura_support.ron,asusdfalls back to thegeneric default for board
G614FP(only theKeyboardpower zone, no per-keysupport). As a result the front bottom Lightbar is never initialised and
stays dark, and
asusctl aura power lightbarhas no effect.This adds a
G614FPentry (Aura device19b6) modelled on the already-testedG614PPentry: per-key keyboard plus theLightbarpower zone. It wasvalidated on the machine by loading the identical entry through the supported
user override
/etc/asusd/asusd_user_ledmodes.ronbefore submitting.Fixes: N/A (no existing issue)
Tested Hardware & Environment
Verification performed:
asusdlogsMatched to G614FP->Matched to 19b6and regenerates
/etc/asusd/aura_19b6.ronwith bothKeyboardandLightbarpower states.
asusctl aura power lightbar --boot --awake --sleep --shutdownandasusctl aura effect static -c <colour>.Notes:
Logozone is intentionally omitted (same asG614PP) because it wasnot tested on this unit.
cargowas notavailable on my machine, so I could not run the local test suite; the
rog-auradata-file tests (sorting / layout links) should run in CI.description. The hardware testing and the final review of the change were
done by me.
Verification and testing:
cargo fmt --all -- --check)cargo clippy --all -- -D warnings/cargo check --all-targets)cargo test --all)cargo cranky)