Skip to content

fix(rog-aura): fix RGB .ron for various G615 - #374

Merged
Ghoul4500 merged 1 commit into
OpenGamingCollective:mainfrom
Pelochus:main
Sep 13, 2026
Merged

Ghoul4500 merged 1 commit into
OpenGamingCollective:mainfrom
Pelochus:main

Conversation

@Pelochus

Copy link
Copy Markdown
Contributor

Description

My previous contribution missed per-key RGB for G615LW. Along the way, I've made minor fixes to other G615 variants that were incorrectly labeled.

Tested Hardware & Environment

  • ASUS Laptop Model: G615LW (ROG Strix G16 2025)
  • Linux Distribution: Bazzite 44 (Fedora 44)
  • Kernel Version: 7.2.3

Verification and testing:

  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My code follows the style guidelines of this project (cargo fmt --all -- --check)
  • My changes generate no new warnings (cargo clippy --all -- -D warnings/cargo check --all-targets)
  • New and existing unit tests pass locally with my changes (cargo test --all)
  • Cranky with 0 warning (cargo cranky)

@coderabbitai

coderabbitai Bot commented Sep 10, 2026

Copy link
Copy Markdown

Review Change StackReview Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: ASSERTIVE

Plan: Advanced

Run ID: d0a5b6e2-9a27-4d10-b435-5f281d0cdec1

📥 Commits

Reviewing files that changed from the base of the PR and between 0bd6f23 and 4154c9d.

📒 Files selected for processing (2)
  • rog-aura/data/aura_support.ron
  • rog-control-center/translations/es/rog-control-center.po

Included review availability: Your plan provides up to 4 included reviews per hour; 3 remain after this review.

📜 Recent review details
⏰ Context from checks skipped due to timeout. (2)
  • GitHub Check: cargo audit (Debian 13 / rustc 1.93)
  • GitHub Check: cargo build --workspace (Ubuntu / rustc 1.93)
🔇 Additional comments (2)
rog-aura/data/aura_support.ron (1)

474-474: LGTM!

Also applies to: 484-484, 493-493, 510-510, 513-513, 519-521

rog-control-center/translations/es/rog-control-center.po (1)

1-1208: LGTM!


📝 Summary

Summary by CodeRabbit

  • Bug Fixes
    • Updated Aura lighting support for ASUS ROG G615JHR, G615LR, and G615LW devices.
    • G615JHR now supports the complete set of per-key basic lighting modes.
    • G615LR no longer includes the logo as a configurable power-zone lighting area.
    • G615LW now uses per-key lighting controls instead of separate zone-based controls.

Walkthrough

The Aura support data updates mode and zone declarations for three ASUS ROG devices. G615JHR gains additional basic modes. G615LR loses the Logo power zone. G615LW changes from zoned to per-key configuration.

Changes

Aura support declarations

Layer / File(s) Summary
Device capability declarations
rog-aura/data/aura_support.ron
G615JHR gains seven basic modes. G615LR removes the Logo power zone. G615LW changes to per-key support with no basic zones.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Suggested labels: rog-aura, fix

Suggested reviewers: scardracs, ghoul4500

Merge Risk: ⚪ Minimal · up to 10514

This change expands Aura support for five ASUS ROG models and adds Spanish Aura translations, with English fallback entries elsewhere. The supplied checks and compatibility evidence indicate no actionable merge-blocking risk remains.

🚥 Pre-merge checks | ✅ 4
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and concisely identifies the main change: fixing ROG Aura RGB configurations for multiple G615 models.
Description check ✅ Passed The description provides a change summary, tested hardware and environment, and completed verification checklist. The optional issue reference is not filled in, but the description is otherwise comple…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@coderabbitai coderabbitai Bot added fix Fix a bug or an issue rog-aura Keyboard / Aura RGB labels Sep 10, 2026

@Ghoul4500 Ghoul4500 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If all G615 variants have the exact same capabilties, they can be collapsed into one entry. the reason we haven't done so is that we can't really be certain of that.

Also in this PR itself, the modified records aren't similar to one another (for example basic zones being an empty array on one while another has 4 keys). If you can verify these, feel free to correct them as well

@Pelochus

Copy link
Copy Markdown
Contributor Author

Thanks, missed those empty arrays. It's something that I assumed should be correct and barely took a look at the code of those.

I've also added Pulse to one of them, it was missing.

I would not merge all G615 into one, apparently some SKUs might be 4 zone rgb for lower cost options (i.e.: RTX xx60/xx70 series)

Please have another look.

@Pelochus
Pelochus requested a review from Ghoul4500 September 10, 2026 20:46
@Pelochus

Copy link
Copy Markdown
Contributor Author

@Ghoul4500 have a chance to take a look?

@Ghoul4500

Copy link
Copy Markdown
Member

I would not merge all G615 into one, apparently some SKUs might be 4 zone rgb for lower cost options (i.e.: RTX xx60/xx70 series)

The records u modified have basic_zones still empty array on some while others have 4 zones. I meant to ask if you had verified these. Also sorry for the late response

@Ghoul4500

Copy link
Copy Markdown
Member

This looks correct otherwise. the PerKey models have all per-key modes and the ones with the 4 basic zones have their respective modes

@Pelochus

Copy link
Copy Markdown
Contributor Author

Hey @Ghoul4500 , yes I've verified these. AFAIK per key models should have empty basic zones array.

If no other concerns I believe this can be merged. Let me know. TIA

@Ghoul4500

Copy link
Copy Markdown
Member

Alright if you have verified which models are per key and which aren't, thenI have no issues. Thank you for the contribution

@Ghoul4500
Ghoul4500 merged commit fa9879e into OpenGamingCollective:main Sep 13, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

fix Fix a bug or an issue rog-aura Keyboard / Aura RGB rog-control-center ROG Control Center GUI

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants