fix(rog-aura): fix RGB .ron for various G615 - #374
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository UI Review profile: ASSERTIVE Plan: Advanced Run ID: 📒 Files selected for processing (2)
Included review availability: Your plan provides up to 4 included reviews per hour; 3 remain after this review. 📜 Recent review details⏰ Context from checks skipped due to timeout. (2)
🔇 Additional comments (2)
📝 SummarySummary by CodeRabbit
WalkthroughThe Aura support data updates mode and zone declarations for three ASUS ROG devices. G615JHR gains additional basic modes. G615LR loses the ChangesAura support declarations
Estimated code review effort: 1 (Trivial) | ~2 minutes Suggested labels: Suggested reviewers: Merge Risk: ⚪ Minimal · up to This change expands Aura support for five ASUS ROG models and adds Spanish Aura translations, with English fallback entries elsewhere. The supplied checks and compatibility evidence indicate no actionable merge-blocking risk remains. 🚥 Pre-merge checks | ✅ 4✅ Passed checks (4 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Ghoul4500
left a comment
There was a problem hiding this comment.
If all G615 variants have the exact same capabilties, they can be collapsed into one entry. the reason we haven't done so is that we can't really be certain of that.
Also in this PR itself, the modified records aren't similar to one another (for example basic zones being an empty array on one while another has 4 keys). If you can verify these, feel free to correct them as well
|
Thanks, missed those empty arrays. It's something that I assumed should be correct and barely took a look at the code of those. I've also added Pulse to one of them, it was missing. I would not merge all G615 into one, apparently some SKUs might be 4 zone rgb for lower cost options (i.e.: RTX xx60/xx70 series) Please have another look. |
|
@Ghoul4500 have a chance to take a look? |
The records u modified have basic_zones still empty array on some while others have 4 zones. I meant to ask if you had verified these. Also sorry for the late response |
|
This looks correct otherwise. the PerKey models have all per-key modes and the ones with the 4 basic zones have their respective modes |
|
Hey @Ghoul4500 , yes I've verified these. AFAIK per key models should have empty basic zones array. If no other concerns I believe this can be merged. Let me know. TIA |
|
Alright if you have verified which models are per key and which aren't, thenI have no issues. Thank you for the contribution |
Description
My previous contribution missed per-key RGB for G615LW. Along the way, I've made minor fixes to other G615 variants that were incorrectly labeled.
Tested Hardware & Environment
Verification and testing:
cargo fmt --all -- --check)cargo clippy --all -- -D warnings/cargo check --all-targets)cargo test --all)cargo cranky)