Skip to content

include output json in caching hash#1890

Open
atravitz wants to merge 8 commits intoquickrun_resumefrom
quickrun_resume_try_hashing
Open

include output json in caching hash#1890
atravitz wants to merge 8 commits intoquickrun_resumefrom
quickrun_resume_try_hashing

Conversation

@atravitz
Copy link
Contributor

@atravitz atravitz commented Mar 24, 2026

this is a first pass at how we could implement what I described here: #1848 (comment)

Checklist

  • All new code is appropriately documented (user-facing code must have complete docstrings).
  • Added a news entry, or the changes are not user-facing.
  • Ran pre-commit: you can run pre-commit locally or comment on this PR with pre-commit.ci autofix.

Manual Tests: these are slow so don't need to be run every commit, only before merging and when relevant changes are made (generally at reviewer-discretion).

Developers certificate of origin

@atravitz atravitz requested a review from IAlibay March 24, 2026 00:33
@codecov
Copy link

codecov bot commented Mar 24, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 91.91%. Comparing base (bd8efe6) to head (ef4f2cd).

Additional details and impacted files
@@                 Coverage Diff                 @@
##           quickrun_resume    #1890      +/-   ##
===================================================
+ Coverage            91.90%   91.91%   +0.01%     
===================================================
  Files                  206      206              
  Lines                18256    18287      +31     
===================================================
+ Hits                 16778    16809      +31     
  Misses                1478     1478              
Flag Coverage Δ
fast-tests 91.91% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Member

@IAlibay IAlibay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To be discussed?

@atravitz atravitz force-pushed the quickrun_resume_try_hashing branch from 27243b2 to a23571a Compare March 25, 2026 21:06
@atravitz atravitz requested a review from IAlibay March 25, 2026 21:56
@atravitz atravitz marked this pull request as ready for review March 25, 2026 21:56
@atravitz atravitz changed the title first pass at adding caching with output json include output json in caching hash Mar 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants