-
Notifications
You must be signed in to change notification settings - Fork 61
Simple picklist to control sync/async mode #4323
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4323 +/- ##
==========================================
+ Coverage 89.29% 89.33% +0.04%
==========================================
Files 425 425
Lines 19990 19991 +1
==========================================
+ Hits 17850 17859 +9
+ Misses 2140 2132 -8 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few small comments:
webhook_reply- I don't think this field should be nullable. The migration hasnull: falsewith a default, and the Ecto schema hasdefault: :before_start. See inline comments on the TypeScript type definitions. But please verify what I am saying is correct... this came up a few times during separate Claude/reviews.- I committed directly to update some conditional styling in TriggerForm to use the
cn()utility function. - It would be nice to also add an interaction test in
TriggerForm.test.tsx. Current tests are only verifying rendering but don't test the actual user interaction for this feature. Something like this:
test('updates trigger when user changes response mode', async () => {
const trigger = workflowStore.getSnapshot().triggers[0];
const { user } = render(<TriggerForm trigger={trigger} />, {...});
const select = await screen.findByLabelText('Response Mode');
await user.selectOptions(select, 'after_completion');
// Verify Y.Doc was updated
await waitFor(() => {
const updatedTrigger = workflowStore.getSnapshot().triggers[0];
expect(updatedTrigger.webhook_reply).toBe('after_completion');
});
});
elias-ba
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @taylordowns2000 nice work on this one. I have few observations. What do you think ?
assets/test/collaborative-editor/components/inspector/TriggerForm.test.tsx
Show resolved
Hide resolved
…ibility Links the help text to the webhook_reply select field so screen readers automatically announce the description when users focus on the field.
9e919a7 to
39204ed
Compare
|
Added some update to make sure unsaved changes considers this new field |
Description
This PR closes #4321 , adding the picklist for async/sync mode triggers. (It's the second part of #3785, which has now been used for a month or two.)
Validation steps
Additional notes for the reviewer
AI Usage
Please disclose how you've used AI in this work (it's cool, we just want to know!):
You can read more details in our Responsible AI Policy
Pre-submission checklist
:owner,:admin,:editor,:viewer)