PE - DOCS - Delineate the boundary-response torque from the KineticForces NTV torque - #424
Draft
logan-nc wants to merge 1 commit into
Draft
PE - DOCS - Delineate the boundary-response torque from the KineticForces NTV torque#424logan-nc wants to merge 1 commit into
logan-nc wants to merge 1 commit into
Conversation
…rces NTV torque GPEC now reports torque through two distinct constructions and will gain a third (the gpout_dw psi-resolved profile, issue #423): the PE scalar is the boundary quadratic form of the anti-Hermitian plasma inductance, equal to the volume-integrated Euler-Lagrange kinetic torque only for converged self-consistent solutions, and a distinct construction from the KineticForces energy-space NTV evaluation. State this in the struct docstring, the HDF5 long_name, and at the computation site so no output is just called 'torque'. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01LzbLFQKyuRE5DYZmLokKmk
Contributor
|
This pull request is missing an assignee and a reviewer. If you are not ready to name them, mark this pull request as a draft. |
logan-nc
added a commit
that referenced
this pull request
Aug 22, 2026
… PR #424 Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01LzbLFQKyuRE5DYZmLokKmk
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Small clarity fix prompted by issue #423's torque cross-validation:
PerturbedEquilibrium/Energies/toroidal_torquewas annotated simply as "net toroidal torque on the plasma", which invites direct comparison withKineticForces/<method>/total_torque— a distinct construction.This PR renames nothing (clean-break renames deferred until the gpout_dw port lands, issue #423) but states the delineation in all three places a user would look: the
PerturbedEquilibriumStatedocstring, the HDF5long_name, and the computation site inResponse.jl. The delineation:−2n·Im⟨Φ_tot, Λ⁻¹Φ_tot⟩/4— the anti-Hermitian boundary quadratic form. Equals the volume-integrated Euler–Lagrange kinetic torque for converged self-consistent solutions (δW surface-term identity); their numerical difference is a solution/grid diagnostic.gpout_dw, unported — issue Port gpout_dw / gpout_dw_matrix (psi-resolved torque response profiles and matrices) as the grid-logic diagnostic #423): same model, volume-resolved.KineticForces/): independent energy-space bounce-average evaluation; agreement with the above tests whether the EL matrices faithfully discretize the drift-kinetic operator.🤖 Generated with Claude Code
https://claude.ai/code/session_01LzbLFQKyuRE5DYZmLokKmk