Skip to content

CI - REFACTOR - Remove the auto-merge label wrapper workflow - #405

Merged
logan-nc merged 2 commits into
developfrom
refactor/remove-auto-merge-wrapper
Aug 20, 2026
Merged

CI - REFACTOR - Remove the auto-merge label wrapper workflow#405
logan-nc merged 2 commits into
developfrom
refactor/remove-auto-merge-wrapper

Conversation

@logan-nc

Copy link
Copy Markdown
Collaborator

Release note

  • Audience: developers
  • Numerical impact: none
  • Migration: Arm auto-merge with the Enable auto-merge button in the merge box instead of the auto-merge label. The label has been deleted.

Removes the custom auto-merge workflow. GitHub's native auto-merge, which the workflow was only triggering, covers the same capability directly.

Why

.github/workflows/auto-merge.yaml did not implement merging. It ran gh pr merge --auto, which is GitHub's native auto-merge — so the workflow was a label-driven trigger for the merge-box button, nothing more. allow_auto_merge is true on this repository, so the button is already available to anyone with write access and no capability is lost.

Two reasons to prefer the button over the label:

  • Two ways to arm a merge is worse than one for something this consequential, given that no PR may be merged without human review.
  • The workflow merged using GITHUB_TOKEN, so anyone able to apply a label could arm auto-merge even without permission to merge it themselves. The button requires write access.

The one thing lost is at-a-glance visibility: a label shows in the pull request list, whereas the button's state only shows inside the PR.

Regression report

No files under src/ are touched; the change deletes a single workflow file, so there is nothing for the harness to move.

Notes for reviewers

The auto-merge label has already been deleted, and no open pull request was carrying it, so nothing in flight was disturbed. With the label gone the workflow is inert regardless, but leaving a dead workflow that holds contents: write is worse than removing it.

Branch protection on develop is unchanged by this and still requires one approving review plus the Documentation and Tests checks — native auto-merge waits on those exactly as the label-driven path did.

The title follows the commit convention proposed in #404. Note that the pr-conventions check will not run on this PR, because that workflow does not exist on develop yet.

The workflow only called `gh pr merge --auto`, which is GitHub's own auto-merge.
With `allow_auto_merge` enabled on the repository, the merge box button offers
the same capability directly, so the label added a second path to arming a merge
without adding any function.

It also widened access slightly: the workflow merged using GITHUB_TOKEN, so
anyone able to apply a label could arm auto-merge even without permission to
merge. The button requires write access.

The `auto-merge` label has been deleted; no open pull request carried it.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>

@matt-pharr matt-pharr left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@logan-nc logan-nc added the minor Not worth reporting label Aug 20, 2026
@logan-nc
logan-nc enabled auto-merge August 20, 2026 19:03
@github-actions github-actions Bot added refactor Behavior-preserving restructuring and removed minor Not worth reporting labels Aug 20, 2026
@github-actions

Copy link
Copy Markdown
Contributor

This pull request is missing a reviewer.

If you are not ready to name them, mark this pull request as a draft.
docs/development/contributors.md suggests lead developers to ask.
Merging is not blocked here, but no pull request may be merged without human review.

@logan-nc
logan-nc merged commit 1623c07 into develop Aug 20, 2026
7 checks passed
@logan-nc
logan-nc deleted the refactor/remove-auto-merge-wrapper branch August 20, 2026 19:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

refactor Behavior-preserving restructuring

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants