FFS - REFACTOR - Extract local stability into standalone LocalStability module (refactor plan PR 2) - #387
Merged
matt-pharr merged 1 commit intoAug 15, 2026
Conversation
logan-nc
approved these changes
Aug 15, 2026
logan-nc
left a comment
Collaborator
There was a problem hiding this comment.
Another great re-org.
Human diff review complete - are you happy Claude??
Collaborator
|
@matt-pharr I assigned you to hit merge in case there was a fancy ordering you preferred for your PRs |
Collaborator
|
🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR 2 of the refactor sequence in
REFACTOR_PLAN.md(§4). Stacked on #381 (refactor/riccati-unification) — this PR shows only the LocalStability extraction; review/merge #381 first. When #381 merges and its branch is deleted, GitHub retargets this PR todevelop. The remaining work (original PRs 3–5) lands as a single combined interface PR onrefactor/forcefreestates-result, stacked on this one.What this does
Ballooning.jl(Mercier D_I, resistive interchange D_R, high-n ballooning Δ′ scans and s–α drivers) out of ForceFreeStates into a new top-levelLocalStabilitymodule viagit mv(history preserved).LocalStabilitydepends only on Equilibrium plus math libraries — no stability-solver state. The HDF5 groupLocalStability/*(from ALL - REFACTOR - Module-mirroring CamelCase HDF5 schema (issue #226, PR A) #363) already matches the module name, so no dataset paths change.ForceFreeStatesControlargument (it only ever suppliedverbose) in favor of averbose::Bool=falsekwarg:compute_local_stability(equil; verbose),ballooning_alpha_boundary(equil; …),ballooning_alpha_boundaries,ballooning_qprime_boundaries,scan_delta_prime_map,ballooning_delta_prime_map,ballooning_qprime_delta_prime_map,compute_ballooning_stability!.ctrl.local_stability_flagstays in[ForceFreeStates](the driver reads it); a[LocalStability]TOML section is deliberately out of scope.main_from_inputs),test/runtests_resist_eval.jl,examples/DIIID-like_ideal_example/analyze_example.jl(also sheds a throwaway ForceFreeStatesControl construction), Analysis docstring cross-references.Ballooning.jlremoved from stability.md's@autodocsPages; new@autodocsblock forLocalStabilityin ballooning.md (satisfiescheckdocs=:exports); architecture.md module list/dependency tree updated to eight modules.No numerical changes: pure code motion plus signature mechanics.
Verification
runtests_resist_eval.jl63/63 andruntests_fullruns.jl17/17 pass on this tree; zero staleForceFreeStates.*ballooning*references (grep across src/test/examples/benchmarks/docs).build_docs_local.jl)--refs refactor/riccati-unification,local; expected:LocalStability/*datasets identical) — pasted here before this PR leaves draftThis PR must not be merged without a third-party human reviewer's approval — non-negotiable (see
REFACTOR_PLAN.md§8).🤖 Generated with Claude Code