Conversation
new aerodyn input format - removed AFAeroMod and WakeMod is now Wake_Mod Co-authored-by: DT4015 <devoncambo@hotmail.com>
* Update of FAST.Farm for windows * Fixing unittests
* Updates from welib * Adding IEA15 model * Adding Example 0, update Example 1 so it can run on github action * Adapting Example 2 for FAST.Farm so it can run on github action * Adapting Example 3 for FAST.Farm so it can run on github action * Adding real_all io unittest, and verbose flag to unittest
|
@mayankchetan, can you review this? |
There was a problem hiding this comment.
Pull Request Overview
This PR merges development changes to main, primarily including fixes for unit tests and updates to IEA 15MW turbine airfoil data files.
- Fixes broken unit tests that had been failing for some time
- Updates numerous IEA 15MW airfoil polar data files with new aerodynamic coefficients
- Adds verbose output to test commands for better debugging
Reviewed Changes
Copilot reviewed 77 out of 173 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| Multiple IEA-15-240-RWT_AeroDyn15_Polar_*.dat | New airfoil polar data files containing aerodynamic coefficients for the IEA 15MW turbine |
| IEA-15-240-RWT_AF49_Coords.txt | New airfoil coordinate file defining the shape of airfoil section 49 |
| data/.gitignore | Adds .lin and .sum.yaml files to gitignore |
| Makefile | Adds verbose flag to unittest command |
| .github/workflows/development-pipeline.yml | Adds verbose flag to unittest command in CI pipeline |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
mayankchetan
left a comment
mayankchetan
left a comment
There was a problem hiding this comment.
That's a lot of changes and updates!! Thanks Emmanuel! :)
|
@rthedin had worked quite a bit to get the toolbox to generate FF input files that run with TurbSim again. things weren't really working yet and I opened rthedin#3 waiting for a review. I've reviewed this PR and so much has changed that I am not sure anymore whether this will work with TurbSim. @ebranlard can you confirm? |
| !------- FILTERS ---------------------------------------------------------- | ||
| 1.00810 ! F_LPFCornerFreq - Corner frequency (-3dB point) in the low-pass filters, [rad/s] | ||
| 0.70000 ! F_LPFDamping - Damping coefficient {used only when F_FilterType = 2} [-] | ||
| 1 ! F_NumNotchFilts - Number of notch filters placed on sensors | ||
| 3.3550 ! F_NotchFreqs - Natural frequency of the notch filters. Array with length F_NumNotchFilts | ||
| 0.0000 ! F_NotchBetaNum - Damping value of numerator (determines the width of notch). Array with length F_NumNotchFilts, [-] | ||
| 0.2500 ! F_NotchBetaDen - Damping value of denominator (determines the depth of notch). Array with length F_NumNotchFilts, [-] | ||
| 0 ! F_GenSpdNotch_N - Number of notch filters on generator speed | ||
| 0 ! F_GenSpdNotch_Ind - Indices of notch filters on generator speed | ||
| 1 ! F_TwrTopNotch_N - Number of notch filters on tower top acceleration signal | ||
| 1 ! F_TwrTopNotch_Ind - Indices of notch filters on tower top acceleration signal | ||
| 0.62830 ! F_SSCornerFreq - Corner frequency (-3dB point) in the first order low pass filter for the setpoint smoother, [rad/s]. | ||
| 0.20944 ! F_WECornerFreq - Corner frequency (-3dB point) in the first order low pass filter for the wind speed estimate [rad/s]. | ||
| 0.17952 ! F_YawErr - Low pass filter corner frequency for yaw controller [rad/s]. | ||
| 0.213000 1.000000 ! F_FlCornerFreq - Natural frequency and damping in the second order low pass filter of the tower-top fore-aft motion for floating feedback control [rad/s, -]. |
There was a problem hiding this comment.
Why did you change some of these values when compared to the IEA 15MW RWT repository v.1.1.15
|
@ebranlard I'm working on this PR. Will keep posting comments as I go and will let you know when I'm done. |
6 participants
Contains:
Mostly affects FAST.Farm.