Added MoorDyn support to FastFarmCaseCreation#37
Open
ombahiwal wants to merge 3 commits intoOpenFAST:devfrom
Open
Added MoorDyn support to FastFarmCaseCreation#37ombahiwal wants to merge 3 commits intoOpenFAST:devfrom
MoorDyn support to FastFarmCaseCreation#37ombahiwal wants to merge 3 commits intoOpenFAST:devfrom
Conversation
Collaborator
|
Thanks @ombahiwal for this PR. We will hold off on this PR for now, as there is more comprehensive PR including support for MoorDyn (and HydroDyn and SeaState) -- PR #40. Some of the elements of this PR might be incorporated (like rotation of the mooring system). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
for issue #17
"Add support for MoorDyn"
following the same style of HydroDyn, and updated dict as template file params from the previous PR #36
mDynfilenameto thetemplateFilesdictionary.FFCaseCreationclass to integrate MoorDyn.Note:
Please note that the tests for MoorDyn rotation and copy are added as comments in
test_moordyn_support.pyin order to avoid pytest command from failing. As discussed earlier, I lack the domain knowledge for this module, I request you to check if the test case is appropriate with your template files. So, I suggest this PR could be taken to adevbranch to worked on later by a domain expert.