Repository navigation
Distinguish PR previews with a DEV PREVIEW title and banner - #15
Merged
Merged
Conversation
|
Preview closed This PR is closed and its preview has been removed. |
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR previews previously looked like the production dashboard, making them easy to confuse during review. The publisher now adds a
[DEV PREVIEW] PR #<number>browser title, a sticky amber banner with links to the PR and main dashboard, a brown header, and a warm background to both preview dashboards and demos.Apply the appearance from the trusted publisher to every authorized preview, including retained builds whose artifacts have expired. Reconciliation is idempotent, and production files remain unchanged. The banner is a visual cue; the existing OWNERS authorization policy is unchanged.
Validation:
python3 -m tests.check, including Chrome checks for the title, banner, links, different header color, persistence while scrolling, and layout at 390px width.