Repository navigation
Fix flaky browser profile cleanup in public checks - #14
Merged
Merged
Conversation
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Public checks could fail after every browser assertion passed because a Chrome child was still writing to its temporary profile when Python removed the directory. This caused the
Directory not emptyfailure in PR #10's first CI attempt.Start Chrome in its own POSIX process group and stop the group before removing the profile, even if the browser parent has already exited. Allow 10 seconds for graceful termination, then kill remaining processes and allow another 10 seconds for exit. Ignore zombies, which cannot write files, while still reporting live processes that cannot be stopped. Preserve the existing parent-process cleanup on non-POSIX systems.
Validation:
python3 -m tests.checkpasses, including the real Chrome browser checks. Browser and production-data assertions are unchanged.