Repository navigation
fix(formplayer): prevent signature gestures from triggering swipes - #1032
Merged
r0ssing merged 2 commits intoOct 28, 2026
Merged
Conversation
Contributor
Author
|
Hi @najuna-brian, @Mishael-2584, @r0ssing , I’ve completed the changes and opened the PR. When you get a chance, could you please review it and let me know if there’s anything I should adjust? Thank you. |
r0ssing
self-requested a review
October 28, 2026 07:31
r0ssing
approved these changes
Oct 28, 2026
r0ssing
left a comment
Member
There was a problem hiding this comment.
Thanks @Grace256c ! This looks good - stopping the even propagation is the right way to fix this! 👍
Contributor
Author
|
Thank you, @r0ssing I really appreciate the review and confirmation. |
This was referenced Oct 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What & Why
Prevent touch gestures that begin on the signature canvas from propagating to the parent swipe layout.
Previously, drawing a signature horizontally could also be interpreted as a page swipe. The signature canvas now owns its drawing gestures while normal swipe navigation remains unchanged elsewhere.
Closes #1023.
Type of Change
Component(s) Changed
Testing
Added regression coverage verifying that touch gestures on the signature canvas do not bubble to a parent gesture handler.
Local verification:
pnpm run lintpnpm run format:checkpnpm run buildThe full Formplayer suite initially showed one unrelated NumberStepper test failure. That test passed when rerun independently, and the NumberStepper files are unchanged by this PR.
Checklist
Closes #1023