Skip to content

fix(formplayer): prevent signature gestures from triggering swipes - #1032

Merged
r0ssing merged 2 commits into
OpenDataEnsemble:devfrom
Grace256c:fix/formplayer-signature-swipe
Oct 28, 2026
Merged

r0ssing merged 2 commits into
OpenDataEnsemble:devfrom
Grace256c:fix/formplayer-signature-swipe

Conversation

@Grace256c

@Grace256c Grace256c commented Oct 27, 2026 •

Copy link
Copy Markdown
Contributor

What & Why

Prevent touch gestures that begin on the signature canvas from propagating to the parent swipe layout.

Previously, drawing a signature horizontally could also be interpreted as a page swipe. The signature canvas now owns its drawing gestures while normal swipe navigation remains unchanged elsewhere.

Closes #1023.

Type of Change

  • Bug fix
  • New feature / enhancement
  • Refactor / cleanup
  • Documentation
  • Chore / other

Component(s) Changed

  • formulus (React Native mobile app)
  • formulus-formplayer (form WebView UI)
  • synkronus (Go backend)
  • synkronus-cli (command-line client)
  • synkronus-portal (web admin UI)
  • desktop (Tauri app)
  • packages (tokens / components)
  • Documentation / DevOps / CI

Testing

  • Added/updated tests
  • Manually tested
  • Not applicable

Added regression coverage verifying that touch gestures on the signature canvas do not bubble to a parent gesture handler.

Local verification:

  • Signature renderer tests passed
  • pnpm run lint
  • pnpm run format:check
  • pnpm run build

The full Formplayer suite initially showed one unrelated NumberStepper test failure. That test passed when rerun independently, and the NumberStepper files are unchanged by this PR.

Checklist

  • Pre-flight checks for changed packages passed (lint / format / tests)
  • Breaking changes (if any) have migration steps
  • Related issue linked, e.g. Closes #1023

@Grace256c

Copy link
Copy Markdown
Contributor Author

Hi @najuna-brian, @Mishael-2584, @r0ssing , I’ve completed the changes and opened the PR. When you get a chance, could you please review it and let me know if there’s anything I should adjust? Thank you.

@r0ssing r0ssing left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Grace256c ! This looks good - stopping the even propagation is the right way to fix this! 👍

@Grace256c

Copy link
Copy Markdown
Contributor Author

Thank you, @r0ssing I really appreciate the review and confirmation.

@r0ssing
r0ssing merged commit 2224d0e into OpenDataEnsemble:dev Oct 28, 2026
19 checks passed
@github-project-automation github-project-automation Bot moved this from Triage to Done in ODE Community Board Oct 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Development

Successfully merging this pull request may close these issues.

[Formplayer] Drawing a signature sideways swipes to another page

2 participants