Repository navigation
fix(cli): accept likert, duration and sub-observation formats in bundle validation - #1026
Merged
Mishael-2584 merged 1 commit intoOct 26, 2026
Merged
Conversation
Lemeri123
force-pushed
the
fix/cli-builtin-formats
branch
from
October 23, 2026 11:52
7a58169 to
dd914ae
Compare
najuna-brian
approved these changes
Oct 25, 2026
Contributor
|
Brilliant work. @Lemeri123 Thanks for the fix. Both validation paths now share the same format list, and the three additions match Formplayer’s built-in renderers. Unknown formats are still rejected as expected. I ran go test ./pkg/validation/ against dd914ae, and it passed. CI is also green. No blocking findings from me. Approved from my side. @najuna-brian |
Mishael-2584
approved these changes
Oct 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1016
synk app-bundle uploadwas rejecting bundles that uselikert,durationorsub-observation, even though Formplayer renders these natively. The validator had two hard-coded copies of the known-formats list and neither had these three.I moved the list into one shared variable with a small helper so the two checks can't drift apart again, and added the missing formats. I also added a test with a bundle using all three, plus one that makes sure an unknown format is still rejected.
Ran
go test ./pkg/validation/locally and it's all green.