fix: emit SSE errors for chat failures - #24
Merged
haolpku merged 1 commit intoSep 20, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The /api/chat generator propagated provider/loop exceptions after partial output, leaving clients with a truncated stream and no terminal error event. Convert ordinary stream failures into the existing SSE error event while preserving cancellation propagation. The message contains only the exception type, avoiding provider text or credentials in the wire response. Added an ASGI regression that raises after a partial event. Validation: 2 HTTP API tests passed; no route or success-response changes; targets main.