Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions datamind/capabilities/skills/service.py
Original file line number Diff line number Diff line change
Expand Up @@ -59,6 +59,8 @@ async def load(self) -> dict[str, int]:
self._by_name = {m.name: m for m in manifests}
manifests = list(self._by_name.values())
indexed = 0
if not manifests and self._embedding and self._store:
await self._store.reset()
if manifests and self._embedding and self._store:
ids = [m.name for m in manifests]
texts = [m.full_text for m in manifests]
Expand Down
49 changes: 49 additions & 0 deletions datamind/tests/test_skills.py
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@

from datamind.capabilities.skills import (
SkillManifest,
SkillsService,
discover_skills,
load_skill,
)
Expand Down Expand Up @@ -62,6 +63,54 @@ def test_discover_skills_scans_subdirs(tmp_path: Path):
assert [m.name for m in ms] == ["a", "b"]


class _SkillEmbedding:
dimension = 1

async def embed_texts(self, texts):
return [[float(index)] for index, _ in enumerate(texts)]


class _SkillVectorStore:
def __init__(self):
self.items = {}

async def reset(self):
self.items.clear()

async def add(self, ids, texts, embeddings, metadatas):
self.items = {
item_id: (text, metadata)
for item_id, text, metadata in zip(ids, texts, metadatas)
}


@pytest.mark.asyncio
async def test_skill_reload_clears_index_when_all_manifests_are_removed(tmp_path: Path):
skill_dir = tmp_path / 'alpha'
skill_dir.mkdir()
manifest = skill_dir / 'SKILL.md'
manifest.write_text(
'---\nname: alpha\ndescription: Alpha\n---\n\nBody\n',
encoding='utf-8',
)
store = _SkillVectorStore()
service = SkillsService(
skills_dir=tmp_path,
profile_skills_dir=tmp_path / 'profile',
embedding=_SkillEmbedding(),
vector_store=store,
)

await service.load()
assert sorted(store.items) == ['alpha']

manifest.unlink()
stats = await service.load()

assert stats['manifests'] == 0
assert store.items == {}


# ---------------------------------------------------------- code skills ---


Expand Down