fix: reject malformed embedding indices before lossy coercion - #14
Merged
haolpku merged 1 commit intoSep 17, 2026
Merged
Conversation
Contributor
Author
|
@haolpku — Could you please review the strict embedding-response validation fix and merge it if CI confirms the full suite and compatibility expectations? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@haolpku
Summary
The OpenAI-compatible embedding provider now validates response indices before sorting or coercing them.
Root cause
The old path called
int(row["index"]), allowing fractional values such as0.9and1.9to become0and1. The completeness check then accepted a malformed response. Python booleans also passed the numeric coordinate check becauseboolsubclassesint.Change
ExternalServiceError.Regression coverage
The focused tests cover fractional, boolean, string, negative, duplicate, and out-of-range indices; boolean coordinates; valid reordering; and the no-retry rule for deterministic schema errors.
Verification:
python -m pytest -q— 202 passing, 5 optional SDK tests skipped.No network service or embedding quality claim is made; this is response-shape validation only.
Please review and merge if CI is green.