Skip to content

fix hosted issue trigger gating #73

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
romgenie wants to merge 1 commit into
base: main
Choose a base branch
from
+93 −5
Open

fix hosted issue trigger gating #73

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 9 additions & 5 deletions deploy/coven-github/coven_github_adapter.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -315,10 +315,12 @@ def build_task_from_event(event_name, delivery_id, payload, policy):
if event_name == "issue_comment":
issue = payload.get("issue") or {}
comment = payload.get("comment") or {}
if payload.get("action") != "created":
return ignored(base, "unsupported_issue_comment_action")
if not mentioned(comment.get("body"), policy):
return ignored(base, "issue_comment_without_mention")
if not trigger_enabled(policy, "issue_mention"):
return ignored(base, "issue_mention_not_enabled")
if not trigger_enabled(policy, "issue_comment.created"):
return ignored(base, "issue_comment_not_enabled")
if issue.get("pull_request"):
base.update(
{
Expand Down Expand Up @@ -352,9 +354,11 @@ def build_task_from_event(event_name, delivery_id, payload, policy):
if event_name == "pull_request_review_comment":
comment = payload.get("comment") or {}
pull_request = payload.get("pull_request") or {}
if payload.get("action") != "created":
return ignored(base, "unsupported_pr_review_comment_action")
if not mentioned(comment.get("body"), policy):
return ignored(base, "pr_review_comment_without_mention")
if not trigger_enabled(policy, "pr_review_comment"):
if not trigger_enabled(policy, "pull_request_review_comment.created"):
return ignored(base, "pr_review_comment_not_enabled")
base.update(
{
Expand All @@ -380,13 +384,13 @@ def build_task_from_event(event_name, delivery_id, payload, policy):
action = payload.get("action")
if action not in ("assigned", "labeled"):
return ignored(base, "unsupported_issue_action")
if action == "assigned" and not trigger_enabled(policy, "issue_assigned"):
if action == "assigned" and not trigger_enabled(policy, "issues.assigned"):
return ignored(base, "issue_assigned_not_enabled")
if action == "assigned" and not issue_assigned_to_bot(issue, policy):
return ignored(base, "issue_assigned_to_unmanaged_user")
if action == "labeled" and not labels_include_trigger(issue.get("labels"), policy):
return ignored(base, "issue_label_not_enabled")
if action == "labeled" and not trigger_enabled(policy, "issue_label"):
if action == "labeled" and not trigger_enabled(policy, "issues.labeled"):
return ignored(base, "issue_label_not_enabled")
base.update(
{
Expand Down
84 changes: 84 additions & 0 deletions deploy/coven-github/test_coven_github_adapter.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,90 @@ def test_route_signed_delivery_reports_missing_secret(self):
self.assertEqual(result["status"], 500)
self.assertIn("GITHUB_WEBHOOK_SECRET", result["error"])

def test_issue_opened_is_not_a_work_trigger(self):
adapter = load_adapter()

task = adapter.build_task_from_event(
"issues",
"delivery-issue-opened",
{
"action": "opened",
"installation": {"id": 123456},
"repository": {
"id": 987654321,
"full_name": "OpenCoven/example",
"clone_url": "https://github.com/OpenCoven/example.git",
"default_branch": "main",
},
"issue": {
"number": 43,
"title": "Installer is slow",
"body": "A diagnostic issue, not a bot task.",
"labels": [],
"assignees": [],
},
},
{
"enabled_triggers": [
"issues.labeled",
"issue_comment.created",
"pull_request_review_comment.created",
],
"trigger_labels": ["coven:fix"],
"bot_usernames": ["coven-cody[bot]"],
"familiar": {
"id": "cody",
"display_name": "Cody",
"model": "openai/gpt-5.5",
"skills": [],
},
"publication": {"mode": "record_only"},
},
)

self.assertEqual(task["state"], "ignored")
self.assertEqual(task["ignored_reason"], "unsupported_issue_action")

def test_labeled_issue_uses_webhook_trigger_name_policy(self):
adapter = load_adapter()

task = adapter.build_task_from_event(
"issues",
"delivery-issue-labeled",
{
"action": "labeled",
"installation": {"id": 123456},
"repository": {
"id": 987654321,
"full_name": "OpenCoven/example",
"clone_url": "https://github.com/OpenCoven/example.git",
"default_branch": "main",
},
"issue": {
"number": 44,
"title": "Fix it",
"body": "Please fix it.",
"labels": [{"name": "coven:fix"}],
},
},
{
"enabled_triggers": ["issues.labeled"],
"trigger_labels": ["coven:fix"],
"bot_usernames": ["coven-cody[bot]"],
"familiar": {
"id": "cody",
"display_name": "Cody",
"model": "openai/gpt-5.5",
"skills": [],
},
"publication": {"mode": "record_only"},
},
)

self.assertEqual(task["state"], "queued")
self.assertEqual(task["trigger"], "issue_assigned")
self.assertEqual(task["task"]["kind"], "fix_issue")

def test_prepare_review_context_rejects_stale_pr_head_evidence(self):
adapter = load_adapter()

Expand Down
Loading